Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

pip fallback install should really honour non exact version number #341

Merged
merged 5 commits into from
Nov 15, 2018
Merged

pip fallback install should really honour non exact version number #341

merged 5 commits into from
Nov 15, 2018

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Nov 15, 2018

This is a hopefully working approach for #338 that actually isn't working.

@bsipocz bsipocz changed the title pip fallback install should really honour non exact version number WIP: pip fallback install should really honour non exact version number Nov 15, 2018
@bsipocz bsipocz force-pushed the pip_honour_version_take2 branch 3 times, most recently from 2548fad to fd15e42 Compare November 15, 2018 02:45
@bsipocz
Copy link
Member Author

bsipocz commented Nov 15, 2018 •
edited
Loading

There is a good chance that the version fall back at the sip, matplotlib, sphinx install section is buggy as well, but figuring that out will be beyond the scope of this PR (given that testing this whole infrastructure is quite timeconsuming, etc.) it's probably not buggy just confusing.

@bsipocz bsipocz force-pushed the pip_honour_version_take2 branch from 7f9ddaa to f0648f5 Compare November 15, 2018 03:46
@bsipocz bsipocz force-pushed the pip_honour_version_take2 branch from f0648f5 to 0c128f9 Compare November 15, 2018 03:50
@bsipocz
Removing absolutely non working code snippet, and adding the version …
1ce29d1 
…checking to the part where all dependencies are dealt with
@bsipocz bsipocz force-pushed the pip_honour_version_take2 branch from 0c128f9 to 1ce29d1 Compare November 15, 2018 04:04
@bsipocz bsipocz changed the title WIP: pip fallback install should really honour non exact version number pip fallback install should really honour non exact version number Nov 15, 2018
@bsipocz
Copy link
Member Author

bsipocz commented Nov 15, 2018

If all green, then this should be good to go.

@bsipocz bsipocz force-pushed the pip_honour_version_take2 branch from 6fa464f to 8c36533 Compare November 15, 2018 05:48
@bsipocz bsipocz merged commit e2783b5 into astropy:master Nov 15, 2018
@bsipocz bsipocz mentioned this pull request Nov 27, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
merge-when-ci-passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bsipocz