Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround: Remove -R option #70

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 23, 2023

This is to fix #67, and a follow-up PR to pytest-astropy is coming.

@bsipocz bsipocz added this to the 0.4.1 milestone Aug 23, 2023
@bsipocz bsipocz requested a review from pllim August 23, 2023 03:45
@bsipocz bsipocz force-pushed the ENH_remote_R_option branch from 1bcb554 to 37c1ab5 Compare August 23, 2023 04:02
@bsipocz bsipocz force-pushed the ENH_remote_R_option branch from 37c1ab5 to 903ea39 Compare August 23, 2023 04:24
@@ -1,7 +1,8 @@
0.4.1 (unreleased)
==================

- No changes yet.
- Reverting the short option of ``-R`` due to a clash with ``pytest-leaks``.
The short option is added to ``pytest-astropy`` instead. [#70]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But won't that make any package that install pytest-astropy to be incompatible with pytest-leaks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would. But -R was around in the astropy ecosystem forever, so I don't expect much clash in real life scenarios.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is a nice compromise. Packages don't really need the meta package to function if there is indeed a clash down the road.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the order of operation? Does astropy/pytest-astropy#55 go in first or this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order doesn't matter as the metapackage config explicitly states incompatibility with 0.4.0, the only release that has this option.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll let you manage the merge order as you desire. Thanks!

@bsipocz bsipocz merged commit d355c3f into astropy:main Sep 13, 2023
@bsipocz bsipocz deleted the ENH_remote_R_option branch September 13, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict single letter option "-R"
2 participants