-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround: Remove -R option #70
Conversation
…ed to pytest-astropy instead
1bcb554
to
37c1ab5
Compare
37c1ab5
to
903ea39
Compare
@@ -1,7 +1,8 @@ | |||
0.4.1 (unreleased) | |||
================== | |||
|
|||
- No changes yet. | |||
- Reverting the short option of ``-R`` due to a clash with ``pytest-leaks``. | |||
The short option is added to ``pytest-astropy`` instead. [#70] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But won't that make any package that install pytest-astropy
to be incompatible with pytest-leaks
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would. But -R was around in the astropy ecosystem forever, so I don't expect much clash in real life scenarios.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it is a nice compromise. Packages don't really need the meta package to function if there is indeed a clash down the road.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the order of operation? Does astropy/pytest-astropy#55 go in first or this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order doesn't matter as the metapackage config explicitly states incompatibility with 0.4.0, the only release that has this option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'll let you manage the merge order as you desire. Thanks!
This is to fix #67, and a follow-up PR to pytest-astropy is coming.