Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements for interpolation with map_coordinates #448

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

astrofrog
Copy link
Member

Split out from #447, this is needed to make workers not use up too much memory when using dask.distributed, but doesn't quite work yet as the memmap copying doesn't seem to always work (some tests failing)

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.90%. Comparing base (dcd497b) to head (4b3d7b8).
Report is 4 commits behind head on main.

Files Patch % Lines
reproject/array_utils.py 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
- Coverage   91.26%   90.90%   -0.37%     
==========================================
  Files          25       25              
  Lines        1065     1077      +12     
==========================================
+ Hits          972      979       +7     
- Misses         93       98       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astrofrog astrofrog marked this pull request as ready for review June 14, 2024 21:15
@astrofrog astrofrog changed the title Improve memory efficiency of map_coordinates Performance improvements for interpolation with map_coordinates Jul 26, 2024
@astrofrog astrofrog merged commit 70536f0 into astropy:main Jul 26, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant