Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging calls and fix a couple of dask-related issues #450

Merged
merged 7 commits into from
Jun 27, 2024

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Jun 17, 2024

@keflavich - this might help understand what reproject is doing. Probably should document this, need to do:

import logging
logging.basicConfig(level=logging.INFO)

to see any messages

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 82.92683% with 7 lines in your changes missing coverage. Please review.

Project coverage is 91.26%. Comparing base (8014869) to head (2ab5757).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
reproject/mosaicking/coadd.py 71.42% 6 Missing ⚠️
reproject/common.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   91.52%   91.26%   -0.27%     
==========================================
  Files          25       25              
  Lines        1027     1065      +38     
==========================================
+ Hits          940      972      +32     
- Misses         87       93       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astrofrog astrofrog requested a review from Cadair June 17, 2024 12:52
@astrofrog
Copy link
Member Author

@Cadair - how do you feel about this in principle? Any downsides?

@astrofrog astrofrog merged commit 51379b1 into astropy:main Jun 27, 2024
11 of 16 checks passed
@astrofrog astrofrog mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant