Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Use pydata-sphinx-theme in conf/v2.py #59

Merged
merged 7 commits into from
Jun 6, 2023

Conversation

pllim
Copy link
Member

@pllim pllim commented May 24, 2023

Switch from astropy-sphinx-theme to pydata-sphinx-theme.

The changes here are plucked from astropy/astropy#14477 (thanks, @saimn !)

To see real changes between v1 and v2, run this locally:

diff sphinx_astropy/conf/v2.py sphinx_astropy/conf/v1.py

Used in:

@pllim
Copy link
Member Author

pllim commented May 24, 2023

Close/reopen to trigger CI. It was disabled due to lack of activity.

@pllim pllim closed this May 24, 2023
@pllim pllim reopened this May 24, 2023
@pllim pllim marked this pull request as ready for review May 25, 2023 19:23
@pllim pllim requested review from saimn and eteq May 25, 2023 19:23
@pllim
Copy link
Member Author

pllim commented May 25, 2023

This should be now fully backward compatible.

:shipit:

sphinx_astropy/conf/v2.py Outdated Show resolved Hide resolved
@hamogu
Copy link
Member

hamogu commented Jun 2, 2023

@eteq You are one of the people who might have feelings on this... We discussed this at the dev telecon and there we all thought this could progress and be merged.

pllim and others added 7 commits June 2, 2023 15:16
and moved custom.css stuff downstream.

Customize copy button to not copy code
prompt or output.

Misc v2 fixes.
by not introducing breaking change to the status quo.
Also remove deprecated function from v2.
because it is repetitive
Copy link
Contributor

@saimn saimn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pllim pllim merged commit 31ea12f into astropy:main Jun 6, 2023
@pllim pllim deleted the pydata-sphinx-theme branch June 6, 2023 17:55
@pllim
Copy link
Member Author

pllim commented Jun 6, 2023

Thanks, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants