-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fr-about #687
base: gql
Are you sure you want to change the base?
Conversation
… except for the carousel of images (v buggy)
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9728246 | Triggered | Airtable API Key | 1d01756 | frontend/src/app/About/index.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
//undefined stuff that was in main branch | ||
$bt-navbar-height: 58px; | ||
$bt-light-text: #8A8A8A; | ||
$bt-base-text: #383838; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have Tailwind colors defined as CSS variables in the src/main.scss
file.
You can reference CSS variables like so:
color: var(--slate-500);
console.log(currContributors) | ||
const base64Root = 'data:image/jpeg;base64,' | ||
|
||
const alumniByGradYear: { [key: number]: contributorStructure[] } = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super important, but you can convert this and the following forEach
loop into a useMemo
React hook using the [Array.prototype.reduce](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/reduce)
function. Memoization will prevent re-renders if they were to occur.
No description provided.