-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core eng] modern CICD #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd strongly recommend using reusable workflows when you have multiple workflows which do practically the same thing:
name: Deploy
on:
workflow_call:
inputs:
environment:
type: string
required: true
...
# All examples
env:
GKE_CLUSTER: main-cluster
GKE_ZONE: us-central1-c
VAR_TAG: ${{ format('tag-{0}', inputs.environment) }}
...
jobs:
deploy:
name: Build and Deploy
runs-on: ubuntu-latest-m
steps:
...
name: Deploy to Production
on:
workflow_dispatch:
push:
branches: ["main"]
paths: ["apps/*"]
jobs:
deploy:
uses: ./.github/workflows/cd.yaml
secrets: inherit
with:
environment: prod
... |
maxmwang
temporarily deployed
to
development
September 29, 2024 00:49
— with
GitHub Actions
Inactive
maxmwang
had a problem deploying
to
development
September 29, 2024 00:52
— with
GitHub Actions
Failure
maxmwang
temporarily deployed
to
development
September 29, 2024 01:04
— with
GitHub Actions
Inactive
maxmwang
temporarily deployed
to
development
September 29, 2024 01:22
— with
GitHub Actions
Inactive
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily building off @Chengming-Li great work on testCICD.
This PR introduces CICD workflows via Github Actions for:
cd-prod.yaml
. Manually triggered, must be reviewed.cd-stage.yaml
. Automatically triggered on push tomaster
(andgql
for now).cd-dev.yaml
. Manually triggered, does not need review.Manually triggered workflows use the workflow dispatch trigger. To trigger these, go into the "Actions" tab, select the correct action on the left panel, then click "Run workflow".
The development workflow also initiates a pod that cleans up the dev install after a certain amount of seconds, inputted from engineers when first running the dev workflow. There is no enforced cap, but please keep this number small.