Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use indexmap version 1.6.2 in async-graphql-value #776

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

terahlunah
Copy link
Contributor

Issue

indexmap 1.7.0 is causing dependency cycles when used alongside certains crates (see tkaitchuck/aHash#95)
Currently, the only fix is to downgrade to indexmap 1.6.2

async-graphql depends on indexmap = "1.6.2"
but async-graphql-value depends on indexmap = "1.7.0"

This is preventing me pinning indexmap to 1.6.2 in my project

Proposed solution

Change async-graphql-value to depend on indexmap = "1.6.2", like async-graphql

No other change is required

@sunli829
Copy link
Collaborator

sunli829 commented Jan 5, 2022

Thanks!

1 similar comment
@sunli829
Copy link
Collaborator

sunli829 commented Jan 5, 2022

Thanks!

@sunli829 sunli829 merged commit 769c6e0 into async-graphql:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants