Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export AsyncConstructor #234

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Export AsyncConstructor #234

merged 1 commit into from
Dec 30, 2019

Conversation

nealeu
Copy link
Contributor

@nealeu nealeu commented Dec 27, 2019

So that Typescript can generate type declarations

fixes #233

So that Typescript can generate type declarations

fixes async-library#233
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c6bc739:

Sandbox Source
romantic-kalam-rvgby Configuration

@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #234 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #234   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files           8        8           
  Lines         424      424           
  Branches      140      148    +8     
=======================================
  Hits          418      418           
  Misses          6        6
Impacted Files Coverage Δ
packages/react-async/src/Async.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b248b9...c6bc739. Read the comment docs.

@ghengeveld ghengeveld merged commit 2648ccc into async-library:next Dec 30, 2019
@ghengeveld
Copy link
Member

Thanks @nealeu! Much appreciated.

@nealeu
Copy link
Contributor Author

nealeu commented Dec 31, 2019

Thanks @ghengeveld. How soon will this get into a release? It's not easy to patch around and we can't use git: npm versions against react-async (or is there another nightly source?)

@nealeu nealeu deleted the patch-1 branch December 31, 2019 09:24
@ghengeveld
Copy link
Member

For the time being you can use the CodeSandbox version pinned above.

@nealeu
Copy link
Contributor Author

nealeu commented Dec 31, 2019

Thanks @ghengeveld. That's a cool feature

@nealeu
Copy link
Contributor Author

nealeu commented Mar 25, 2020

@ghengeveld any chance of a 10.0.1 release for these (this and #236)?

The CodeSandbox approach was okay, but that seems to have timed out. We could do with repeatable builds

@ghengeveld
Copy link
Member

Hey yeah sorry it kind of slipped while I was crunching for an upcoming deadline in my daily job. I'm out of office right now but I'll try to get it released before the end of the week. Does that work for you?

@ghengeveld ghengeveld mentioned this pull request Mar 27, 2020
@ghengeveld
Copy link
Member

Released in v10.0.1

@nealeu
Copy link
Contributor Author

nealeu commented Mar 27, 2020

Thanks @ghengeveld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncConstructor needs to be exported
2 participants