-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export AsyncConstructor #234
Conversation
So that Typescript can generate type declarations fixes async-library#233
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c6bc739:
|
Codecov Report
@@ Coverage Diff @@
## next #234 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 8 8
Lines 424 424
Branches 140 148 +8
=======================================
Hits 418 418
Misses 6 6
Continue to review full report at Codecov.
|
Thanks @nealeu! Much appreciated. |
Thanks @ghengeveld. How soon will this get into a release? It's not easy to patch around and we can't use git: npm versions against react-async (or is there another nightly source?) |
For the time being you can use the CodeSandbox version pinned above. |
Thanks @ghengeveld. That's a cool feature |
@ghengeveld any chance of a 10.0.1 release for these (this and #236)? The CodeSandbox approach was okay, but that seems to have timed out. We could do with repeatable builds |
Hey yeah sorry it kind of slipped while I was crunching for an upcoming deadline in my daily job. I'm out of office right now but I'll try to get it released before the end of the week. Does that work for you? |
Released in v10.0.1 |
Thanks @ghengeveld |
So that Typescript can generate type declarations
fixes #233