-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat reinitialize #62
Conversation
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 98.69% 98.71% +0.02%
==========================================
Files 9 9
Lines 691 703 +12
Branches 162 169 +7
==========================================
+ Hits 682 694 +12
Misses 9 9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, and thanks for the effort! 👍
I have just a couple of notes. Thanks for including tests, that's very helpful.
@all-contributors please add @noelyoo for code, ideas |
I've put up a pull request to add @noelyoo! 🎉 |
Hello I would like to know why this PR was closed? |
Hi @maximenathan. The reason this was closed is because the implementation that @neutiyoo came up with did not match the mental model of reinitializing the component as if it was destroyed and recreated. After some discussion in this thread he decided it would be best not to merge this PR because it would only complicate the library while there's an alternative solution available (for his use case at least). If you are in need of this feature, can you explain your use case for it? If there's a good use case without simple enough workaround then I'm happy to add the feature. |
Hi @ghengeveld thanks for your quick response and sorry for the delay |
Description
This PR resolves #58 which is about adding the
reinitialize
method.Breaking changes
N\A
Checklist
Make sure you check all the boxes. You can omit items that are not applicable.
<Async>
anduseAsync()