Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing inaccurate function description in udp::recv #648

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Fixing inaccurate function description in udp::recv #648

merged 1 commit into from
Jan 7, 2020

Conversation

spacekookie
Copy link
Contributor

The recv function only returns the number of bytes. The current
documentation makes the destiction between recv and recv_from
a bit confusing.

k-nasa
k-nasa approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@k-nasa k-nasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@yoshuawuyts
Copy link
Contributor

Filed #661 to fix CI.

@yoshuawuyts yoshuawuyts merged commit e2bb79c into async-rs:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-nasa k-nasa k-nasa approved these changes

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spacekookie @yoshuawuyts @k-nasa