Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce bump workflow as global #67

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Conversation

derberg
Copy link
Member

@derberg derberg commented Aug 11, 2021

Description

do you think it is required to go to all repos mentioned above and remove these scripts:

    "get:version": "echo $npm_package_version",
    "get:name": "echo $npm_package_name",

I kinda do not feel like this is super important, they are not needed but also not harmful, but I'm opened for arguments to go and remove them in all the repositories

Related issue(s)
Resolves #34

@derberg derberg changed the title feat: introduct bump workflow as global feat: introduce bump workflow as global Aug 11, 2021
fmvilas
fmvilas previously approved these changes Aug 12, 2021
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clean 👏

@magicmatatjahu
Copy link
Member

react-component has bump.yaml and not bump.yml so it would not be overwritten + it is not on master branch. @magicmatatjahu can you handle rename in your branch when you will make your next or?

@derberg It's not a good idea to have the bump.yaml file in the master of react-component - why? Bumping version in the master will propagate the changes to the html-template and then we will have the old version in the template... for that we have the bump only in the next branch. Or maybe I'm wrong in this case and it won't be a problem? 🤔

I kinda do not feel like this is super important, they are not needed but also not harmful, but I'm opened for arguments to go and remove them in all the repositories

We can remove them as followups, each person which is "responsible" for given repos :)

@derberg
Copy link
Member Author

derberg commented Aug 12, 2021

Bumping version in the master will propagate the changes to the html-template and then we will have the old version in the template

@magicmatatjahu yes, this is how it works, as in html-template we do not do pre-releases with next react component.
Maybe it is time to release 1.0 of react component 😆

🤔
the only option I see is set HTML template as ignored, but then we need to know that any updates from asyncapi packages will not get automatically into the HTML template

@derberg
Copy link
Member Author

derberg commented Aug 12, 2021

@magicmatatjahu have a look at my change. Of course your bump in next branch will still work and update html-template automatically

@magicmatatjahu
Copy link
Member

the only option I see is set HTML template as ignored, but then we need to know that any updates from asyncapi packages will not get automatically into the HTML template

Maybe we should ignore the react-component and update bump manually in the next branch until the 1.0.0 version? It's better option because HTML template also uses the parser under the hood.

@derberg
Copy link
Member Author

derberg commented Aug 12, 2021

Maybe we should ignore the react-component and update bump manually in the next branch until the 1.0.0 version? It's better option because HTML template also uses the parser under the hood.

it is not possible to ignore global workflows update for a repo only for single workflow, you can ignore for all updates. I think it would be worse to exclude react component from workflows update rather than exclude html-template from dependencies updates, given that parser is not actively developed

@magicmatatjahu
Copy link
Member

Ok then, we can ignore html-template :)

it is not possible to ignore global workflows update for a repo only for single workflow

It sounds as good feature 😄

@derberg
Copy link
Member Author

derberg commented Aug 12, 2021

It sounds as good feature 😄

it does, I was thinking about it for some time already, go ahead and kick of discussion, for now I do not see any other option as providing a list of workflow files and list of repos to ignore - a string of | separated key (filename) and value (list of repos comma separated) split with :. Other options - some config file instead of such encrypted string :)

@derberg
Copy link
Member Author

derberg commented Aug 12, 2021

@magicmatatjahu @fmvilas ok folks, I also cleaned up not needed scripts, wanted to have some fun with new GitHub mindblowing DOT feature 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump workflow needs to be global too, even if used in few repos only
3 participants