Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add '--status' flag to analytics command #1386

Merged
merged 11 commits into from
May 2, 2024

Conversation

peter-rr
Copy link
Member

This PR will add the --status flag to the analytics command in order to show the current status of analytics for metrics collection.

Related issue(s)
Relates to #859

@peter-rr peter-rr changed the title feat: add '--status' flag to asyncapi config analytics command feat: add '--status' flag to analytics command Apr 23, 2024
@peter-rr
Copy link
Member Author

⚠️ PR still in progress. Not ready for review yet.

@peter-rr
Copy link
Member Author

PR ready for review 👍
cc @Amzani

@peter-rr
Copy link
Member Author

/ptal

@asyncapi-bot
Copy link
Contributor

@Amzani @derberg @magicmatatjahu @Souvikns @Shurtu-gal Please take a look at this PR. Thanks! 👋

src/commands/config/analytics.ts Outdated Show resolved Hide resolved
@peter-rr peter-rr requested a review from Shurtu-gal May 2, 2024 08:52
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/commands/config/analytics.ts Outdated Show resolved Hide resolved
Co-authored-by: Khuda Dad Nomani <32505158+KhudaDad414@users.noreply.github.com>
Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peter-rr
Copy link
Member Author

peter-rr commented May 2, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit bb380c1 into asyncapi:master May 2, 2024
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@peter-rr peter-rr deleted the feat/analytics-status-flag branch May 17, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants