-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate cupid
in cli using the relation
command
#143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Great stuff, @arjungarg07! My only concern is that the command is not a verb. We decided to follow the form
|
Yeah @fmvilas , I thought of using the verb |
🤔 I see what you mean. Maybe it should be something like For sure it can't be |
What about |
🤔 It might sound as you're generating the relations but the relations are already there, you're just "finding" them and generating a diagram, isn't it? |
I didn't think in that way, in that case |
Yeah, now what worries me is that clash with |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What about
|
Yeah, this could be done. |
@arjungarg07 not sure if this is intuitive. Look at #129 (comment). I think it should go under @fmvilas have a look as you were involved here |
Yeah, I still think it's better if we stick to |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@arjungarg07 hey is this one ready for review?
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
@arjungarg07 hey, not sure if you noticed but |
@derberg what would be the final command look like? |
I think mostly suggested was this could maybe also be integrated with EDAVisualizer @jonaslagoni ? so one command, but underneath different tools would be used |
@arjungarg07 yo, should we keep it open? |
@derberg I had some doubts, to be resolved(asked above in the thread). Maybe, would open a new PR. |
up to you 😃 |
oh wait, sorry, which doubts are not yet solved? |
@arjungarg07 I'm guessing we should close it, right? |
So does it mean that this issue is open to other contributors @derberg ?? |
yes, but since Arjun is the maintainer of cupid, let's first confirm if this issue makes sense. @arjungarg07 what are your plans with cupid, do you plan to continue maintain it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the example folder can be moved into https://github.com/asyncapi/cli/tree/master/test/fixtures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arjungarg07 there has been a recent change in the folder structure for tests in #712. This can be moved into https://github.com/asyncapi/cli/tree/master/test/integration.
closing for now, I'm in touch with @arjungarg07 to start a process of looking for new maintainers for |
Description
This PR integrates @asyncapi/cupid in cli using the
relation
command.Command usage syntax:
asyncapi relation <context-1/filepath1> <context-2/filepath2> <context-3/filepath3> ...
It has one flag:
--type
which determines the output syntax of the relations and if not provided, would output default output syntax.Related issue(s)
#47