Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add description for the start command in AsyncAPI CLI (#1534) #1537

Merged
merged 3 commits into from
Oct 20, 2024

Conversation

toffee-k21
Copy link
Contributor

Description
Fixed #1534
Added description for the start command in AsyncAPI CLI.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@toffee-k21 toffee-k21 changed the title fix: Add description for the start command in AsyncAPI CLI (#1534) fix: add description for the start command in AsyncAPI CLI (#1534) Oct 2, 2024
@AayushSaini101
Copy link
Contributor

LGTM @toffee-k21

@toffee-k21
Copy link
Contributor Author

toffee-k21 commented Oct 20, 2024

Hey @AayushSaini101,

I have resolved the merge conflict. If there are still any issues, please let me know, and I'll be happy to address them.

Copy link

@Shurtu-gal
Copy link
Collaborator

/rtm

@asyncapi-bot asyncapi-bot merged commit 2e5c6cd into asyncapi:master Oct 20, 2024
22 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Souvikns added a commit to Souvikns/cli that referenced this pull request Oct 22, 2024
* chore: update package-lock.json

* fix: add package-lock.json (asyncapi#1542)

* chore: migrate github-action to cli (asyncapi#1487)

* New Github action added for cli

* Added new files in the github-action

* removed monorepo style for github action

* Updated github action with Dockerfile changes

* added command to pack cli for linux, docker build command

* added test-workflow for github-action

* chore: fix docker context

* chore: change docker context

* fix: dockerfile

* changed dockerfile

* fix: dockerfile

* Converted Dockerfile into multi stages

* added github-action folder

* added assets folder to github action image

* deleted act file script

* removed asyncapi.yaml file from .gitignore

* corrected output file for workflow

* updated Dockerfile

* added bundle file

* changed bundle files

* Updated README

* updated output bundle directory

---------

Co-authored-by: asyncapi-bot <bot+chan@asyncapi.io>
Co-authored-by: Ashish Padhy <100484401+Shurtu-gal@users.noreply.github.com>

* feat: update oclif to v4 (asyncapi#1546)

* feat: update oclif to v4

* chore: removed unused dependencies

* Update myhook.ts

* chore: update package-lock.json version (asyncapi#1550)

* fix: add description for the start command in AsyncAPI CLI (asyncapi#1534) (asyncapi#1537)


Co-authored-by: Ashish Padhy <100484401+Shurtu-gal@users.noreply.github.com>

* chore(release): v2.7.1 (asyncapi#1551)

* fix: update npm to latest for windows (asyncapi#1553)

* chore(release): v2.7.2 (asyncapi#1554)

* Update upload-release-assets.yml

---------

Co-authored-by: root <root@LAPTOP-K7PL9FIU>
Co-authored-by: Ashish Padhy <100484401+Shurtu-gal@users.noreply.github.com>
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
Co-authored-by: asyncapi-bot <bot+chan@asyncapi.io>
Co-authored-by: Taufiq Hassan <145540627+toffee-k21@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Description missing for the start command
4 participants