Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolved faulty spinner loading after error in console #1609

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SahilDahekar
Copy link
Contributor

Description

  • Added a try catch to stop spinner if Error is throw by generateModels() func.

Related issue(s)

Resolves #1607

Copy link

changeset-bot bot commented Dec 23, 2024

⚠️ No Changeset found

Latest commit: fbd0f6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@SahilDahekar SahilDahekar changed the title Resolved the spinner loading even after error in console fix: resolved faulty spinner loading after error in console Dec 23, 2024
@SahilDahekar
Copy link
Contributor Author

Although this particular bug is fixed by adding try catch block , I am not very confident in the implementation and working of this command because i tried using interactive mode and it didn't work as it should .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

[BUG] "generate models java" without packageName hangs
1 participant