-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: switch from mocha and chai to the jest #353
Conversation
a64d649
to
b0dc456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry but let us first merge #221
b7dfc94
to
ed35702
Compare
@derberg Done, could you check again? :) |
1957779
to
5a436d3
Compare
@derberg ping, ping :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you share why changes in [src/base.ts](https://github.com/asyncapi/cli/pull/353/files#diff-440b55a9ff9e0486020fc49197f3278d14446306fc0c5d5107b48139c20bfda6)
were needed? and also is oclif upgrade necessary, related to refactoring of tests?
@derberg When I switched to the jest, oclif doesn't recognized errors from Related to the bump of oclif - I made a bump along with the transition to the jest. Between 1.11 and 1.18 there is nothing big that will cause a breaking change in our cli. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but because prod dependency got updated, we should release it as fix:
and indicate it clearly in the description that it is not only refactor of tests really, but core dependency got also upgraded.
I approve but please make sure to make proper adjustments before merge
ec33338
to
a0a5633
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/rtm |
Description
mocha
andchai
to thejest
. Simple reason. Mocha and chai (specifically, ats-node
which transpiles code from TS to JS) has a some problems with importing ESM. I found that problems when I started writing tests for feat: integrate new parser-js #347 and new parser uses new module syntaxes. We still needchai
in devDependencies, because@oclif/test
uses it underneath.@oclif/core
to the latest^1.18.0
version.Related issue(s)
See more #347