Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: new outputs for asyncapi generate models command with new modelina major version #884

Merged
merged 10 commits into from
Nov 21, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Nov 8, 2023

Description
This PR bumps Modelina to v2.

The changes introduced are:

  • Using preferred IDs over anonymous IDs
  • Accurate array types
  • Union type for operation message oneOf
  • then and else now applies to models
  • Now support constant values
  • Optional properties in Kotlin
  • Optional properties in Java
  • Types now support nullable
  • Interface for objects in oneOf for Java

Read more here: https://modelina.org/docs/migrations/version-1-to-2

@derberg derberg changed the title feat!: bump Modelina to v2 feat!: new outputs for asyncapi generate models command with new modelina major version Nov 15, 2023
@derberg
Copy link
Member

derberg commented Nov 15, 2023

@Souvikns @jonaslagoni I updated the title, since this is a PR that will release 1.0 and is a breaking change, we need to make it clear in the title what command is affected.

@jonaslagoni please also specify in description what exactly is changing with generation output, and provide links for more info

@jonaslagoni
Copy link
Member Author

Added link + small description of the improvements @derberg

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
Copy link
Member

derberg commented Nov 21, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 7eaaf23 into asyncapi:master Nov 21, 2023
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni deleted the modelina_bump_2 branch November 21, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants