-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial infra for slack intergration #1131
Conversation
@smoya The working groups part has also been done. Successful workflow runs can be viewed here. Just needs to wait for the added comment #1143 (comment) |
@asyncapi/bounty_team |
Two things left for this to function correctly:-
It would be good to do it in this order as the workflow will run automatically. cc: @derberg @thulieblack |
@derberg a possible workflow can be verification of |
@Shurtu-gal This PR shouldn't have been merged until everything properly configured. Additionally, it seems it's failing here https://github.com/asyncapi/community/actions/runs/9002845962/job/24732067102#step:3:46 |
Yeah, the working group file has been changed in some other PR, just fixed it in #1203 |
Oh, gotcha. Didn't get it when reading your previous comment. Sorry 😓 |
@derberg the only thing left is to add the slack token. https://github.com/asyncapi/community/actions/runs/9011590065 |
Token I shared with you @derberg via Slack DM. 🙏 |
How about changing it to SLACK_INFRA_TOKEN ? |
no strong opinion here - whatever you folks think is the best - even if not renaming is good, I'll accept your decision |
ok, secret |
You mention in the README that we should use a user bot. However, i dont think is needed, also not very secure.
The changes got approved by @thulieblack now. I guess we would need to update the README as well to mention the changes about the scopes |
I will change the README. |
Please @Shurtu-gal confirm it works now🙏 |
@derberg can you rerun the workflow once. |
sorry but which one? one of the latest from https://github.com/asyncapi/community/actions/workflows/slack-integration.yml? |
@smoya still not working https://github.com/asyncapi/community/actions/runs/9095277402/job/24998151071#step:3:1456. Could you try it once locally, if not maybe can try using user token as written in the |
I ran this locally and got the same |
Just curious, what are the disadvantages with user_token as long as it's a bot user 🤔? |
The need of having to maintain a new user, store the credentials somewhere, give permissions to that user, install the app through that user, etc, makes it so complicated VS using bot tokens, which are meant for that. I checked this on my own workspace and indeed it seems only administrators will be able to do such a thing. The permission for creating channels and usergroups are managed globally in the workspace settings; atm for AsyncAPI Workspace, anyone can create channels but not usergroups, so that's what the bot token will be able to do, just as a any other regular user. More context: We would need to move to the solution of having a dedicated user for this bot unfortunately. @thulieblack how can we proceed with this? I know it is a pita, but there is no other solution if we really want this to happen. cc @derberg |
Great @smoya. Do you mind if I put this QA in doc as it may prove to be useful later on. |
Of course! 👍 |
Please let's move any future discussion into the open issue #1072 |
Description
Tasks
Related issue(s)
Fixes #1072