-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: how changes in the spec are introduced #488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AceTheCreator excellent input!
Not sure what @alequetzalli and @fmvilas think but I think it could easily be converted into an article. And then this document from this PR could be a bit "formalized".
I just think docs should be as short as possible. When someone looks into docs, they look for solution, not "story". This is what blog posts are for.
The only thing you can count on is change. That’s especially true in the world of product and system development. So if you are tasked with leading the charge for your company's product development, it is vital that you stay (or become) dynamic. That's why we at AsyncAPI always try to stay dynamic by introducing new changes based on users' requirement, either by adding new features or by removing existing/deprecated ones.
☝🏼 is perfect for article. The style of massage is great!
the same as documentation:
Changes in the specification are released on a regular basis, four times a year with the support of a dedicated release coordinator. Learn more from [the official release process instruction] (https://github.com/asyncapi/spec/blob/master/RELEASE_PROCESS.md).
Anyone can introduce changes. Every change needs a champion who wants to push the change through all the stages of an RFC (request for change) documented in details in [the official contribution guide for the spec](https://github.com/asyncapi/spec/blob/master/CONTRIBUTING.md).
@AceTheCreator you know what I mean?
@alequetzalli @fmvilas what are your thoughts?
@derberg are you suggesting I convert this to an article and extract the docs out of it? |
@AceTheCreator yes, imho this could be a great article, and only the essence should be a documentation but let's first see what others thing. I might be completely wrong |
I agree with @derberg, this PR is a great blog post; but @AceTheCreator, here's some tips for your next iteration of these
|
@derberg and @alequetzalli kindly share your thoughts |
Yeah, I agree this would make a great blog post. And also a good live stream! Just saying :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getting there! ✌🏽
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
Made changes suggested by grammerly
@alequetzalli I basically copied the whole content and pasted it into the Grammarly essay checker. I resolved the suggested changes but it says there's more but I have to have access to their premium package :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another review 😄✌🏽 ✨✨✨✨ hehe
Co-authored-by: Alejandra Quetzalli <alejandra.olvera.novack@gmail.com>
Co-authored-by: Alejandra Quetzalli <alejandra.olvera.novack@gmail.com>
Co-authored-by: Alejandra Quetzalli <alejandra.olvera.novack@gmail.com>
Co-authored-by: Alejandra Quetzalli <alejandra.olvera.novack@gmail.com>
Thanks for the reviews @alequetzalli. Any other suggestions? |
Co-authored-by: Alejandra Quetzalli <alejandra.olvera.novack@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good 😄
The image below visualizes the whole process of how changes are introduced to the spec in a single glance. | ||
|
||
```mermaid | ||
sequenceDiagram |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diagram is awesome but it links wrong elements I think
cause it looks like, for example, that it is Specification
that performs review, not Maintainer
. Also looks like Specification
looks for release coordinator, not Maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @derberg what do you mean by the specification looks for release coordinator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about my proposal?
Makes sense. I'll update the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, since you work on this one, and we also plan to release spec 2.6 this months, and we do not have release coordinator, maybe you consider being one, so you will see in action the process? just a hint, no obligation
I think this would be a perfect opportunity for me. Thanks for bringing it up
Updated the PR @derberg @alequetzalli |
@AceTheCreator just to confirm, so you want to merge it before you complete the release coordination task? isn't it better to do release 2.6 and then you will see if something needs approval here? we are not in rush right? |
You are right, I'm not merging it yet :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw initial first version, in blog post style was also good.
followup article about the topic from your perspective as release coordinator would be great 😉
I still have the draft of the initial version... So yeah, I'll probably turn it into an article :) |
Description
This PR contains well-detailed documentation of how changes in the specification are introduced
CC @jonaslagoni @fmvilas @derberg @alequetzalli