Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how changes in the spec are introduced #488

Merged
merged 57 commits into from
Mar 14, 2023

Conversation

AceTheCreator
Copy link
Member

Description
This PR contains well-detailed documentation of how changes in the specification are introduced

CC @jonaslagoni @fmvilas @derberg @alequetzalli

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AceTheCreator excellent input!

Not sure what @alequetzalli and @fmvilas think but I think it could easily be converted into an article. And then this document from this PR could be a bit "formalized".

I just think docs should be as short as possible. When someone looks into docs, they look for solution, not "story". This is what blog posts are for.

The only thing you can count on is change. That’s especially true in the world of product and system development. So if you are tasked with leading the charge for your company's product development, it is vital that you stay (or become) dynamic. That's why we at AsyncAPI always try to stay dynamic by introducing new changes based on users' requirement, either by adding new features or by removing existing/deprecated ones.

☝🏼 is perfect for article. The style of massage is great!

the same as documentation:

Changes in the specification are released on a regular basis, four times a year with the support of a dedicated release coordinator. Learn more from [the official release process instruction] (https://github.com/asyncapi/spec/blob/master/RELEASE_PROCESS.md).

Anyone can introduce changes. Every change needs a champion who wants to push the change through all the stages of an RFC (request for change) documented in details in [the official contribution guide for the spec](https://github.com/asyncapi/spec/blob/master/CONTRIBUTING.md).

@AceTheCreator you know what I mean?

@alequetzalli @fmvilas what are your thoughts?

@AceTheCreator
Copy link
Member Author

@derberg are you suggesting I convert this to an article and extract the docs out of it?

@derberg
Copy link
Member

derberg commented Oct 11, 2022

@AceTheCreator yes, imho this could be a great article, and only the essence should be a documentation

but let's first see what others thing. I might be completely wrong

@quetzalliwrites
Copy link
Member

quetzalliwrites commented Oct 12, 2022

I agree with @derberg, this PR is a great blog post; but docs should be succinct.

@AceTheCreator, here's some tips for your next iteration of these community docs on spec changes:

  • think of the top workflows a spec contributor needs to follow & make those your main headers/sections
  • question every sentence you want to add; longer doesn't mean better, it means a longer document to sift through 👀
  • remove all sentences that ramble about "how we do stuff at AsyncAPI"; we should write sentences that are to the point and only discuss directions on how to introduce spec changes and the process
  • this document has not been through Grammarly; all new written content should be run through Grammarly FIRST before being put up for review

@AceTheCreator
Copy link
Member Author

@derberg and @alequetzalli kindly share your thoughts

@fmvilas
Copy link
Member

fmvilas commented Oct 14, 2022

Yeah, I agree this would make a great blog post. And also a good live stream! Just saying :)

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting there! ✌🏽

AceTheCreator and others added 7 commits October 18, 2022 14:17
Co-authored-by: Alejandra Quetzalli  <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli  <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli  <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli  <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli  <alejandra.quetzalli@postman.com>
Co-authored-by: Alejandra Quetzalli  <alejandra.quetzalli@postman.com>
Made changes suggested by grammerly
@AceTheCreator
Copy link
Member Author

@alequetzalli I basically copied the whole content and pasted it into the Grammarly essay checker. I resolved the suggested changes but it says there's more but I have to have access to their premium package :(

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another review 😄✌🏽 ✨✨✨✨ hehe

AceTheCreator and others added 4 commits December 12, 2022 14:34
Co-authored-by: Alejandra Quetzalli  <alejandra.olvera.novack@gmail.com>
Co-authored-by: Alejandra Quetzalli  <alejandra.olvera.novack@gmail.com>
Co-authored-by: Alejandra Quetzalli  <alejandra.olvera.novack@gmail.com>
Co-authored-by: Alejandra Quetzalli  <alejandra.olvera.novack@gmail.com>
@AceTheCreator
Copy link
Member Author

Thanks for the reviews @alequetzalli. Any other suggestions?

AceTheCreator and others added 2 commits December 12, 2022 14:40
Co-authored-by: Alejandra Quetzalli  <alejandra.olvera.novack@gmail.com>
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good 😄

@AceTheCreator
Copy link
Member Author

@derberg @fmvilas any suggestions?

The image below visualizes the whole process of how changes are introduced to the spec in a single glance.

```mermaid
sequenceDiagram
Copy link
Member

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @derberg what do you mean by the specification looks for release coordinator?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-01-11 at 21 18 41

what do you think about my proposal?

also, since you work on this one, and we also plan to release spec 2.6 this months, and we do not have release coordinator, maybe you consider being one, so you will see in action the process? just a hint, no obligation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about my proposal?

Makes sense. I'll update the PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, since you work on this one, and we also plan to release spec 2.6 this months, and we do not have release coordinator, maybe you consider being one, so you will see in action the process? just a hint, no obligation

I think this would be a perfect opportunity for me. Thanks for bringing it up

@AceTheCreator
Copy link
Member Author

Updated the PR @derberg @alequetzalli

@derberg
Copy link
Member

derberg commented Jan 20, 2023

@AceTheCreator just to confirm, so you want to merge it before you complete the release coordination task? isn't it better to do release 2.6 and then you will see if something needs approval here? we are not in rush right?

@AceTheCreator
Copy link
Member Author

@AceTheCreator just to confirm, so you want to merge it before you complete the release coordination task? isn't it better to do release 2.6 and then you will see if something needs approval here? we are not in rush right?

You are right, I'm not merging it yet :)

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw initial first version, in blog post style was also good.

followup article about the topic from your perspective as release coordinator would be great 😉

@AceTheCreator
Copy link
Member Author

btw initial first version, in blog post style was also good.

followup article about the topic from your perspective as release coordinator would be great 😉

I still have the draft of the initial version... So yeah, I'll probably turn it into an article :)

@AceTheCreator AceTheCreator merged commit a5f3837 into asyncapi:master Mar 14, 2023
@AceTheCreator AceTheCreator deleted the docs branch March 14, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants