Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: all ticket types are rendered #403

Closed

Conversation

NamanSriva
Copy link

fix: This PR fixes the ways tickets are being rendered. Earlier only upcoming tickets were rendered but now all the tickets including ended or upcoming are rendered and displayed some more info about tickets(description). Also improved the UI so that while hovering tickets do not overlap on each other.

Screenshot (94)

Related issue(s)
Fixes #395

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cc5c6aa
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/670c07eaf4fef50008de7cce
😎 Deploy Preview https://deploy-preview-403--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashmit-coder
Copy link
Collaborator

Hey @NamanSriva the changes look good, could you just make it so that the active tickets are on top in the mobile view and others below it.

cc: @AceTheCreator , this looks way suitable to our design in my opinion.

@NamanSriva
Copy link
Author

@ashmit-coder sure I'll do it ASAP

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome changes @NamanSriva but wouldn't it be even better if tickets renders in carousel?

Also disable/reduce the overlay effect onHover

cc @ashmit-coder

@ashmit-coder
Copy link
Collaborator

Awesome changes @NamanSriva but wouldn't it be even better if tickets renders in carousel?

Also disable/reduce the overlay effect onHover

I do agree on the overlay effect.

about the carousel, ig it will make sense considering uniformity. So yeah a carousel sounds good , but just in desktop view.
I think for mobile view plane linear scroll works better.

@NamanSriva NamanSriva closed this Oct 13, 2024
@NamanSriva NamanSriva force-pushed the fix/all-tickets-rendered branch from e6a9f88 to cc5c6aa Compare October 13, 2024 17:48
@ashmit-coder
Copy link
Collaborator

Hey @NamanSriva why did you close the pr?

@NamanSriva
Copy link
Author

@ashmit-coder actually there was error in naming the branch and it failed some tests while doing commit.

@ashmit-coder
Copy link
Collaborator

@ashmit-coder actually there was error in naming the branch and it failed some tests while doing commit.

Okay so you reopening another pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the way the ticket section is being rendered
3 participants