feat: updates hamburger menu and navbar #458
Conversation
Tanuj1718
requested review from
AceTheCreator,
thulieblack and
Mayaleeeee
as code owners
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Tanuj1718
changed the title
Tanuj1718
changed the title
|
Do we need this change @AceTheCreator @ashmit-coder |
|
Hey @Tanuj1718 the black colour of the navbar looks quiet unpleasing. I think the issue was just to make the hamburger icon sticky to provide better mobility for mobile users. |
|
@ashmit-coder Oh my bad! Should I make it sticky for all devices because everytime user has to scroll to the top for accessing navigation options or the feature should be only for mobile devices? |
|
@Tanuj1718, sorry i'd have to close this PR as someone is already working on a fix that's currently been reviewed |
Oh ! No problem, will try to contribute in other ways. |
Description
screenrecording.mp4
Related issue(s)
Fixes #455