Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distinguish header and logo colors, added proper logo styles #493

Closed
wants to merge 2 commits into from

Conversation

Tanmayshi
Copy link

@Tanmayshi Tanmayshi commented Dec 14, 2024

fix: distinguish header and logo colors, added proper logo styles
Improvement: Updated the logo colors to align with the proper color scheme for better visual clarity.
Additional Change: Enhanced the UI by improving the contrast between header and logo elements, making it more user-friendly.
Related issue(s)
Fixes #484

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Dec 14, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit be8b7ee
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/676158771e2402000855728b
😎 Deploy Preview https://deploy-preview-493--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -17,7 +17,7 @@ function Sponsors({eventSponsors,financialSponsor}) { //eventSponsors,financial
orchestrate an unforgettable celebration.
</Paragraph>
</div>
<Heading typeStyle='heading-md' className='text-white mt-10 sm:text-2xl sm:mt-5'>Event and Host Sponsor</Heading>
<Heading typeStyle='heading-md' className='text-gray-800 mt-10 sm:text-2xl sm:mt-5'>Event and Host Sponsor</Heading>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lighter shade is appreciated. (also try with stale)

@@ -186,7 +186,7 @@ export default function Home() {
</div>
</div>
<div id='sponsors' className='mt-20'>
<Sponsors eventSponsors={[{image:'/img/apidays.png',websiteUrl:"https://www.apidays.global/"}]} financialSponsor={[{image:"/img/graviteeio.svg" , websiteUrl: "https://www.gravitee.io/",className:"w-[250px] h-[50px]" } , {image:"/img/postman.png" ,websiteUrl:"https://www.postman.com/",className:"w-[240px] h-[70px]"}]} />
<Sponsors eventSponsors={[{image:'/img/apidays_2.webp',websiteUrl:"https://www.apidays.global/"}]} financialSponsor={[{image:"/img/graviteeIo_1.png" , websiteUrl: "https://www.gravitee.io/",className:"w-[250px] h-[50px]" } , {image:"/img/postman_1.png" ,websiteUrl:"https://www.postman.com/",className:"w-[240px] h-[70px]"}]} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is no need to change the logo, the logo are taken from the official branding i believe

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly fix your PR title as suggested by the bot :)

@Tanmayshi Tanmayshi changed the title Fixed header and logo color distinction and added proper logo colors #484 fix: distinguish header and logo colors, added proper logo styles Dec 17, 2024
@Tanmayshi
Copy link
Author

"Hi @AceTheCreator,
I have updated the PR title as per the Conventional Commit guidelines (fix: distinguish header and logo colors, added proper logo styles). Please review the changes and let me know if there's anything else to address. 😊"

@AceTheCreator
Copy link
Member

"Hi @AceTheCreator, I have updated the PR title as per the Conventional Commit guidelines (fix: distinguish header and logo colors, added proper logo styles). Please review the changes and let me know if there's anything else to address. 😊"

I think you should apply suggested changes from @TenzDelek 🤔

@Tanmayshi Tanmayshi closed this Dec 19, 2024
@Tanmayshi Tanmayshi deleted the fix-header-logo-colors branch December 19, 2024 23:12
@TenzDelek
Copy link
Contributor

I think the contributor don't want to work on this issue looking at the deleted branch. Therefore I will be taking the issue from here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design]: Colour distinction between h1 and logo
3 participants