feat: throw errors, do not log them #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmvilas
approved these changes
Feb 17, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BOLT04
added a commit
to BOLT04/server-api
that referenced
this pull request
Feb 26, 2022
This is necessary to leverage the changes made by: asyncapi/converter-js#99
magicmatatjahu
pushed a commit
to BOLT04/server-api
that referenced
this pull request
Mar 24, 2022
This is necessary to leverage the changes made by: asyncapi/converter-js#99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Throw errors not only log them. Add unit tests. CLI also works.
Related issue(s)
Needed for asyncapi/cli#188, asyncapi/server-api#26