Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up the repository #121

Merged
merged 22 commits into from
Jul 18, 2023
Merged

Conversation

sambhavgupta0705
Copy link
Member

Description
This PR clean up the files which are needed to be moved to other repositories .
Continuation /inspiration : #112

  • Delete _config.yaml, schema.json, package-lock.json and package.json files
  • Delete Test, extension/http and extension/sqs folders.
  • Create a md file for describing a twitter extension.

Related issue(s)

reference : #104 #1237

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sambhavgupta0705
Copy link
Member Author

@derberg PTAL and provide some feedback about what else need to be upgraded.

@sambhavgupta0705
Copy link
Member Author

cc: @fmvilas

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Thanks for picking that one up

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
extensions/twitter/README.md Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

README.md Outdated Show resolved Hide resolved
@derberg derberg changed the title fix: clean up the repository chore: clean up the repository Jul 10, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at my comment from #112 (review) where I address the structure of twitter extension readme. Current readme is not accurate, as it should talk about x-twitter extension and how it should be use.

@sambhavgupta0705 sambhavgupta0705 requested a review from derberg July 10, 2023 09:21
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sambhavgupta0705 left few comments.

sambhavgupta0705 and others added 7 commits July 11, 2023 14:25
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
README.md Outdated Show resolved Hide resolved
@derberg derberg requested a review from fmvilas July 11, 2023 10:16
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also remove the following files: .github/workflows/if-nodejs-pr-testing.yml and .github/workflows/if-nodejs-release.yml, .github/workflows/if-nodejs-version-bump.yml, .github/workflows/bump.yml

@sambhavgupta0705
Copy link
Member Author

@derberg did the changes

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmvilas wanna have a look before we merge?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Great clean up, @sambhavgupta0705!

@derberg
Copy link
Member

derberg commented Jul 18, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 46617b1 into asyncapi:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants