Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjusted Min/Max datatype for draft07 compliance #100

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

ivanalayan15
Copy link

@ivanalayan15 ivanalayan15 commented May 7, 2022

Description

Adjust minimum, maximum, exclusiveMaximum, exclusiveMinimum from Integer to data type
going to BigDecimal to Integer to adopt Draft-08

Update Schema.java and related unit test that has been broke due to data type change
Unit test result below
Screen Shot 2022-05-07 at 3 45 55 PM

Related issue(s)
Resolves #97 and Resolves #96

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ivanalayan15 ivanalayan15 changed the title Adjusted Min/Max Values in the Schema to be BigDecimal instead of Integer fix: Adjusted Min/Max Values in the Schema to be BigDecimal instead of Integer May 7, 2022
@ivanalayan15 ivanalayan15 changed the title fix: Adjusted Min/Max Values in the Schema to be BigDecimal instead of Integer fix: adjusted Min/Max datatype for draft07 compliance May 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added stale and removed stale labels Sep 5, 2022
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jan 5, 2023
@Pakisan Pakisan changed the base branch from master to develop February 15, 2023 21:22
@Pakisan
Copy link
Member

Pakisan commented Feb 15, 2023

Hi @ivanalayan15,

Thanks for PR! Can you resolve conflicts?

@Pakisan Pakisan removed the stale label Feb 15, 2023
@Pakisan Pakisan merged commit 3f44790 into asyncapi:develop Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants