-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: seesharp: Using dependency management / partOfProperty to render optional types with question mark #1037
Conversation
test/generators/csharp/presets/__snapshots__/JsonSerializerPreset.spec.ts.snap
Outdated
Show resolved
Hide resolved
test/generators/csharp/presets/__snapshots__/NewtonsoftSerializerPreset.spec.ts.snap
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this PR, type
and name
were interchangeable because they contained the same value. Now they no longer do that, and we were not strict in the past when what was used 😅
Other then that you have some linting errors 🙂
Updated. Thanks, I missed that over all the changes! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Do you mean the to model and GetValue methods? They are there because the core models are not meant to depend on any outside library, that is what the presets are for 🙂 You could definitely argue that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zaytsevand it seems you have merged the dependency manager changes into the branch again. I have a feeling you have tainted your local next
branch as you merged it into your branch here: d2a2885
Description
Related issue(s)
Fixes #941