-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Components, Security Requirement(s) models and other improvements #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comment 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@fmvilas @magicmatatjahu I added the |
I decided to include more things into this PR so we do the review at once. I just added:
|
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
According to asyncapi/parser-js#663 (comment), |
@magicmatatjahu can you please take care of this PR while Sergio is out? |
@fmvilas No problem, I'm up-to-date with it :) |
What's missing here, @magicmatatjahu? Can we already merge it or are you still working on it? |
Is there something blocking this PR to be merged? Cc @magicmatatjahu @jonaslagoni Otherwise, i feel we can proceed. |
@smoya New things from 3.0.0 like server's |
I would rather merge this one, which is being old enough and with tons of changes and then work on top of it. otherwise this PR is growing and lacking context with every day it passes. |
wdyt about this @jonaslagoni @magicmatatjahu @derberg @fmvilas ? |
Whatever works best for you guys. Just let's make sure to have this (and the parser) as soon as possible. |
Ok I think we can merge it :) I fixed all bugs that I found. I removed some not implemented methods like In next PR I will add methods/objects related to the 3.0.0 version cc @smoya @jonaslagoni Could you accept it? |
/rtm |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Some tooling need to access
components
directly to components so the model is required. Also addedCorrelationIds
as it was needed by theComponents
model.Examples of why this is needed:
This PR also adds the models for
SecurityRequirement
,MessageExample
and the collection of those,SecurityRequirements
andMessageExamples
.It also includes some fixes on types.