Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: References resolved wrong when parsing is done inside Promise.all() #168

Merged
merged 2 commits into from
Aug 31, 2020
Merged

chore: References resolved wrong when parsing is done inside Promise.all() #168

merged 2 commits into from
Aug 31, 2020

Conversation

derberg
Copy link
Member

@derberg derberg commented Aug 28, 2020 •
edited
Loading

Description

  • References resolved wrong when parsing is done inside Promise.all(). It was caused by the fact that $RefParser was initialized globally and shared in concurrent parsing

@derberg derberg marked this pull request as ready for review August 28, 2020 11:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg derberg changed the title fix: References resolved wrong when parsing done inside Promise.all() fix: References resolved wrong when parsing is done inside Promise.all() Aug 28, 2020
@derberg derberg requested a review from fmvilas August 28, 2020 12:02
@derberg derberg mentioned this pull request Aug 28, 2020
Closed
mauriceackel
mauriceackel approved these changes Aug 28, 2020
View reviewed changes
Copy link

@mauriceackel mauriceackel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derberg derberg changed the title fix: References resolved wrong when parsing is done inside Promise.all() chore: References resolved wrong when parsing is done inside Promise.all() Aug 31, 2020
@derberg derberg merged commit 8dd702a into asyncapi:master Aug 31, 2020
@derberg derberg deleted the concurency branch August 31, 2020 15:32
@KhudaDad414 KhudaDad414 mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauriceackel mauriceackel mauriceackel approved these changes

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derberg @magicmatatjahu @mauriceackel