Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update version for updated spec #289

Merged
merged 2 commits into from
May 28, 2021
Merged

chore: update version for updated spec #289

merged 2 commits into from
May 28, 2021

Conversation

dalelane
Copy link
Contributor

Contributes to: asyncapi/spec#466

Signed-off-by: Dale Lane dale.lane@uk.ibm.com

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.

Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@derberg
Copy link
Member

derberg commented Apr 23, 2021

@dalelane hey, same as in the other PR, please remove manual bump of the parser + can you show what changes had to be done to dist/bundle.js that it is included in the PR?

@dalelane
Copy link
Contributor Author

@derberg the dist/bundle.js update was from running npm run generate:assets but is there automation I should've left that to be done by?

@derberg
Copy link
Member

derberg commented Apr 23, 2021

@dalelane exactly, automation will pic it up as for example here https://github.com/asyncapi/parser-js

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave package.json version and dist/bundle.js out of this PR. Also, left a comment.

package.json Outdated Show resolved Hide resolved
Contributes to: asyncapi/spec#466

Signed-off-by: Dale Lane <dale.lane@uk.ibm.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dalelane
Copy link
Contributor Author

updated - thanks!

@dalelane dalelane requested a review from fmvilas April 24, 2021 11:05
@derberg derberg changed the base branch from master to 2021-06-release May 14, 2021 09:02
@derberg
Copy link
Member

derberg commented May 14, 2021

@dalelane I took the liberty to switch the branch from master to new 2021-06-release so you do not have to do it

package.json Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fmvilas
Copy link
Member

fmvilas commented May 28, 2021

Updated the @asyncapi/specs package myself. It's now using 2.8.0-2021-06-release.1.

@derberg
Copy link
Member

derberg commented May 28, 2021

@fmvilas lgtm, just approve and merge

@fmvilas fmvilas merged commit 589060b into asyncapi:2021-06-release May 28, 2021
@derberg
Copy link
Member

derberg commented May 28, 2021

crap, it was chore so release artifact was not published 🤔

@derberg
Copy link
Member

derberg commented May 28, 2021

maybe next PR with empty commit? thoughts? or manually push directly to release branch? or kinda refert and do it again?

@fmvilas
Copy link
Member

fmvilas commented May 28, 2021

I'd do a PR with empty commit.

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.6.0-2021-06-release.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants