-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update version for updated spec #289
chore: update version for updated spec #289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@dalelane hey, same as in the other PR, please remove manual bump of the parser + can you show what changes had to be done to |
@derberg the dist/bundle.js update was from running |
@dalelane exactly, automation will pic it up as for example here https://github.com/asyncapi/parser-js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave package.json
version and dist/bundle.js
out of this PR. Also, left a comment.
Contributes to: asyncapi/spec#466 Signed-off-by: Dale Lane <dale.lane@uk.ibm.com>
Kudos, SonarCloud Quality Gate passed! |
updated - thanks! |
@dalelane I took the liberty to switch the branch from |
Kudos, SonarCloud Quality Gate passed! |
Updated the |
@fmvilas lgtm, just approve and merge |
crap, it was |
maybe next PR with empty commit? thoughts? or manually push directly to release branch? or kinda refert and do it again? |
I'd do a PR with empty commit. |
🎉 This PR is included in version 1.6.0-2021-06-release.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributes to: asyncapi/spec#466
Signed-off-by: Dale Lane dale.lane@uk.ibm.com