-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add methods and tests for serverVariables #476
feat: add methods and tests for serverVariables #476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however we have to wait for new minor release to merge it, so I will label it as do not merge
. Thanks!
/dnm |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@danielkocot we have now the release branches for |
@derberg can you approve the workflows so they can run? Thanks |
@magicmatatjahu would you mind checking if you can approve this PR? You did but we had to wait for this release to happen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :) @smoya Done.
@smoya Could we merge it as next prerelease? |
@danielkocot As you probably noticed, I merged asyncapi/spec-json-schemas#174, which ended up being properly released as new prerelease The very last step we require from you in this PR is to change |
@danielkocot it seems the branch has now some conflicts with |
/rtm |
Kudos, SonarCloud Quality Gate passed! |
🎉 This PR is included in version 1.15.0-2022-04-release.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Related issue(s)
asyncapi/spec#707, asyncapi/spec#717, asyncapi/spec-json-schemas#174