Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add methods and tests for serverVariables #476

Merged

Conversation

danielkocot
Copy link

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however we have to wait for new minor release to merge it, so I will label it as do not merge . Thanks!

test/models/components_test.js Outdated Show resolved Hide resolved
@magicmatatjahu
Copy link
Member

/dnm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@smoya
Copy link
Member

smoya commented Mar 15, 2022

@danielkocot we have now the release branches for 2.4.0. Would you mind changing the base branch to 2022-04-release ? Thanks!

@danielkocot danielkocot changed the base branch from master to 2022-04-release March 15, 2022 23:16
@smoya smoya mentioned this pull request Mar 21, 2022
55 tasks
@smoya
Copy link
Member

smoya commented Apr 5, 2022

@derberg can you approve the workflows so they can run? Thanks

2022-04-05 at 10 56 47

@smoya
Copy link
Member

smoya commented Apr 5, 2022

@magicmatatjahu would you mind checking if you can approve this PR? You did but we had to wait for this release to happen.

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :) @smoya Done.

@magicmatatjahu
Copy link
Member

@smoya Could we merge it as next prerelease?

@derberg derberg changed the title feat: added methods and tests for serverVariables feat: add methods and tests for serverVariables Apr 20, 2022
@smoya
Copy link
Member

smoya commented Apr 21, 2022

@danielkocot As you probably noticed, I merged asyncapi/spec-json-schemas#174, which ended up being properly released as new prerelease v2.14.0-2022-04-release.2.

The very last step we require from you in this PR is to change @asyncapi/specs pointed version to the latest prerelease, which is v2.14.0-2022-04-release.2 in package.json file and run npm update @asyncapi/specs. Then push the changes.

@smoya
Copy link
Member

smoya commented Apr 21, 2022

@danielkocot it seems the branch has now some conflicts with 2022-04-release. Would you mind fixing them? 🙏

@smoya
Copy link
Member

smoya commented Apr 21, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 382ab29 into asyncapi:2022-04-release Apr 21, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.15.0-2022-04-release.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants