Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove all previous parser code letting a fresh start for 2.0.0 #483

Merged
merged 3 commits into from
Mar 8, 2022

Conversation

smoya
Copy link
Member

@smoya smoya commented Mar 8, 2022

Description

As part of the new rewrite to TypeScript we are gonna work on (See #482), we need to start somewhere, and where better than removing "all" previous code?
Of course, we can still base our development on previous files (they will remain in master obviously!).

Related issue(s)
#482

@smoya
Copy link
Member Author

smoya commented Mar 8, 2022

I feel evil
2022-03-08 at 11 19 44

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GL 😆

@smoya
Copy link
Member Author

smoya commented Mar 8, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit f1cdb92 into asyncapi:next-major Mar 8, 2022
@smoya smoya deleted the feat/cleanup branch March 8, 2022 14:09
magicmatatjahu pushed a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants