Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: init architecture #484

Merged

Conversation

magicmatatjahu
Copy link
Member

Description

  • Setup TS with config
  • Setup Jest with config - write simple tests
  • Setup models folder

Related issue(s)
Part of #482

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Mar 8, 2022
@magicmatatjahu magicmatatjahu requested review from smoya and removed request for fmvilas, derberg, jonaslagoni and asyncapi-bot-eve March 8, 2022 14:19
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -0,0 +1,3 @@
import { BaseModel } from "./base";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ ESM

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 🌔

@magicmatatjahu magicmatatjahu merged commit e40fafc into asyncapi:next-major Mar 8, 2022
@magicmatatjahu magicmatatjahu deleted the next/init-architecture branch March 8, 2022 14:29
magicmatatjahu added a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
derberg pushed a commit that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants