Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add Parser class #511

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

magicmatatjahu
Copy link
Member

Description

Add Parser class. Having a different instance (of Parser) for validation/parsing is important from the point of view of tools for which the rules for Spectral will often change, e.g. server-api. Once the 2.0.0 version of the parser is released, people should be able to upload their own rules. This will also allow us to optimize the validation on the side of e.g. the Studio.

Related issue(s)
Part of #481
Part of #482

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu magicmatatjahu changed the title feat: add Parser class refactor: add Parser class Apr 4, 2022
@magicmatatjahu magicmatatjahu requested a review from smoya April 5, 2022 12:22
@magicmatatjahu
Copy link
Member Author

@jonaslagoni Thanks!

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @magicmatatjahu! 👋🏼
This PR is not up to date with the base branch and can't be merged.
You can add comment to this PR with text: /autoupdate or /au. This way you ask our bot to perform regular updates for you. The only requirement for this to work is to enable Allow edits from maintainers option in your PR. Otherwise the only option that you have is to manually update your branch with latest version of the base branch.
Thanks 😄

@asyncapi-bot asyncapi-bot merged commit 40c40ee into asyncapi:next-major Apr 5, 2022
@magicmatatjahu magicmatatjahu deleted the next/parser-class branch April 5, 2022 13:45
magicmatatjahu added a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
derberg pushed a commit that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants