Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: point @asyncapi/specs package to 2.14.0-2022-04-release.1 #521

Merged
merged 1 commit into from
Apr 14, 2022
Merged

chore: point @asyncapi/specs package to 2.14.0-2022-04-release.1 #521

merged 1 commit into from
Apr 14, 2022

Conversation

smoya
Copy link
Member

@smoya smoya commented Apr 14, 2022 •
edited
Loading

Wondering if I could use some wildcard to not having to do this change every time we wanna merge a change.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@smoya smoya mentioned this pull request Apr 14, 2022
Merged
@derberg
Copy link
Member

derberg commented Apr 14, 2022

yeah, we always tag releases - it should be 2022-04-release
https://www.npmjs.com/package/@asyncapi/specs

but tbh I do not think it will do what you need, as package-lock will anyway lock to specific version, and without update there, it will still use the “old one”

@smoya
Copy link
Member Author

smoya commented Apr 14, 2022

yeah, we always tag releases - it should be 2022-04-release
https://www.npmjs.com/package/@asyncapi/specs

but tbh I do not think it will do what you need, as package-lock will anyway lock to specific version, and without update there, it will still use the “old one”

Yeah, right. A manual npm i will be neded.

@smoya
Copy link
Member Author

smoya commented Apr 14, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 93681ef into asyncapi:2022-04-release Apr 14, 2022
@smoya smoya deleted the chore/updateSpecs branch April 14, 2022 11:39
@derberg
Copy link
Member

derberg commented Apr 14, 2022

@smoya I just noticed you did it as chore so release candidate with it was not released 😄

@smoya smoya mentioned this pull request Apr 14, 2022
Merged
@smoya
Copy link
Member Author

smoya commented Apr 14, 2022

@smoya I just noticed you did it as chore so release candidate with it was not released 😄

Facepalming but #522

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.15.0-2022-04-release.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve

Assignees
No one assigned
Labels
ready-to-merge released on @2022-04-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smoya @derberg @asyncapi-bot