Merge pull request #289 from jonaslagoni/feature/update_next_major_sp…

…ec_with_master

feat: update next major spec with master

.github/workflows/add-good-first-issue-labels.yml

@@ -28,8 +28,10 @@ jobs:
                 break;
               case 'js':
                 values[1] = 'javascript';
+                break;
               case 'markdown':
                 values[1] = 'docs';
+                break;
             }
             if(values.length != 2 || !areas.includes(values[1])){
               const message = `Hey @${context.payload.sender.login}, your message doesn't follow the requirements, you can try \`/help\`.`

.github/workflows/automerge-for-humans-add-ready-to-merge-or-do-not-merge-label.yml

@@ -7,14 +7,14 @@
 
 name: Label PRs # if proper comment added
 
-on: 
-    issue_comment:
-        types: 
-            - created
+on:
+  issue_comment:
+    types:
+      - created
 
 jobs:
   add-ready-to-merge-label:
-    if: > 
+    if: >
       github.event.issue.pull_request && 
       github.event.issue.state != 'closed' && 
       github.actor != 'asyncapi-bot' && 
@@ -25,7 +25,6 @@ jobs:
 
     runs-on: ubuntu-latest
     steps:
-
       - name: Add ready-to-merge label
         uses: actions/github-script@v5
         with:
@@ -64,7 +63,7 @@ jobs:
                        Thanks 😄`
               })
             }
-           
+
   add-do-not-merge-label:
     if: >
       github.event.issue.pull_request &&
@@ -86,7 +85,7 @@ jobs:
               owner: context.repo.owner,
               repo: context.repo.repo,
               labels: ['do-not-merge']
-            }) 
+            })
   add-autoupdate-label:
     if: >
       github.event.issue.pull_request && 
@@ -108,4 +107,4 @@ jobs:
               owner: context.repo.owner,
               repo: context.repo.repo,
               labels: ['autoupdate']
-            }) 
+            })

.github/workflows/automerge-for-humans-remove-ready-to-merge-label-on-edit.yml

@@ -22,14 +22,11 @@ jobs:
           script: |
             const labelToRemove = 'ready-to-merge';
             const labels = context.payload.pull_request.labels;
-            
             const isLabelPresent = labels.some(label => label.name === labelToRemove)
-            
             if(!isLabelPresent) return;
-            
             github.rest.issues.removeLabel({
               issue_number: context.issue.number,
               owner: context.repo.owner,
               repo: context.repo.repo,
               name: labelToRemove
-            }) 
+            })

.github/workflows/if-nodejs-release.yml

@@ -19,6 +19,15 @@ on:
 jobs:
 
   test-nodejs:
+    # We just check the message of first commit as there is always just one commit because we squash into one before merging
+    # "commits" contains array of objects where one of the properties is commit "message"
+    # Release workflow will be skipped if release conventional commits are not used
+    if: |
+      startsWith( github.repository, 'asyncapi/' ) && 
+      (startsWith( github.event.commits[0].message , 'fix:' ) ||
+      startsWith( github.event.commits[0].message, 'fix!:' ) ||
+      startsWith( github.event.commits[0].message, 'feat:' ) ||
+      startsWith( github.event.commits[0].message, 'feat!:' ))
     name: Test NodeJS release on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     strategy:

.github/workflows/issues-prs-notifications.yml

@@ -5,7 +5,6 @@
 name: Notify slack
 
 on:
-
   issues:
     types: [opened, reopened]
 
@@ -16,57 +15,56 @@ on:
     types: [created]
 
 jobs:
+  issue:
+    if: github.event_name == 'issues' && github.actor != 'asyncapi-bot' && github.actor != 'dependabot[bot]' && github.actor != 'dependabot-preview[bot]'
+    name: Notify slack on every new issue
+    runs-on: ubuntu-latest
+    steps:
+      - name: Convert markdown to slack markdown for issue
+        uses: LoveToKnow/slackify-markdown-action@v1.0.0
+        id: issuemarkdown
+        with:
+          text: "[${{github.event.issue.title}}](${{github.event.issue.html_url}}) \n ${{github.event.issue.body}}"
+      - name: Send info about issue
+        uses: rtCamp/action-slack-notify@v2
+        env:
+          SLACK_WEBHOOK: ${{secrets.SLACK_GITHUB_NEWISSUEPR}}
+          SLACK_TITLE: 🐛 New Issue in ${{github.repository}} 🐛
+          SLACK_MESSAGE: ${{steps.issuemarkdown.outputs.text}}
+          MSG_MINIMAL: true
 
-    issue:
-      if: github.event_name == 'issues' && github.actor != 'asyncapi-bot' && github.actor != 'dependabot[bot]' && github.actor != 'dependabot-preview[bot]'
-      name: Notify slack on every new issue
-      runs-on: ubuntu-latest
-      steps:
-        - name: Convert markdown to slack markdown for issue
-          uses: LoveToKnow/slackify-markdown-action@v1.0.0
-          id: issuemarkdown
-          with:
-            text: "[${{github.event.issue.title}}](${{github.event.issue.html_url}}) \n ${{github.event.issue.body}}"
-        - name: Send info about issue
-          uses: rtCamp/action-slack-notify@v2
-          env:
-            SLACK_WEBHOOK: ${{secrets.SLACK_GITHUB_NEWISSUEPR}}
-            SLACK_TITLE: 🐛 New Issue in ${{github.repository}} 🐛
-            SLACK_MESSAGE: ${{steps.issuemarkdown.outputs.text}}
-            MSG_MINIMAL: true
+  pull_request:
+    if: github.event_name == 'pull_request_target' && github.actor != 'asyncapi-bot' && github.actor != 'dependabot[bot]' && github.actor != 'dependabot-preview[bot]'
+    name: Notify slack on every new pull request
+    runs-on: ubuntu-latest
+    steps:
+      - name: Convert markdown to slack markdown for pull request
+        uses: LoveToKnow/slackify-markdown-action@v1.0.0
+        id: prmarkdown
+        with:
+          text: "[${{github.event.pull_request.title}}](${{github.event.pull_request.html_url}}) \n ${{github.event.pull_request.body}}"
+      - name: Send info about pull request
+        uses: rtCamp/action-slack-notify@v2
+        env:
+          SLACK_WEBHOOK: ${{secrets.SLACK_GITHUB_NEWISSUEPR}}
+          SLACK_TITLE: 💪 New Pull Request in ${{github.repository}} 💪
+          SLACK_MESSAGE: ${{steps.prmarkdown.outputs.text}}
+          MSG_MINIMAL: true
 
-    pull_request:
-      if: github.event_name == 'pull_request_target' && github.actor != 'asyncapi-bot' && github.actor != 'dependabot[bot]' && github.actor != 'dependabot-preview[bot]'
-      name: Notify slack on every new pull request
-      runs-on: ubuntu-latest
-      steps:
-        - name: Convert markdown to slack markdown for pull request
-          uses: LoveToKnow/slackify-markdown-action@v1.0.0
-          id: prmarkdown
-          with:
-            text: "[${{github.event.pull_request.title}}](${{github.event.pull_request.html_url}}) \n ${{github.event.pull_request.body}}"
-        - name: Send info about pull request
-          uses: rtCamp/action-slack-notify@v2
-          env:
-            SLACK_WEBHOOK: ${{secrets.SLACK_GITHUB_NEWISSUEPR}}
-            SLACK_TITLE: 💪 New Pull Request in ${{github.repository}} 💪
-            SLACK_MESSAGE: ${{steps.prmarkdown.outputs.text}}
-            MSG_MINIMAL: true
-
-    discussion:
-      if: github.event_name == 'discussion' && github.actor != 'asyncapi-bot' && github.actor != 'dependabot[bot]' && github.actor != 'dependabot-preview[bot]'
-      name: Notify slack on every new pull request
-      runs-on: ubuntu-latest
-      steps:
-        - name: Convert markdown to slack markdown for pull request
-          uses: LoveToKnow/slackify-markdown-action@v1.0.0
-          id: discussionmarkdown
-          with:
-            text: "[${{github.event.discussion.title}}](${{github.event.discussion.html_url}}) \n ${{github.event.discussion.body}}"
-        - name: Send info about pull request
-          uses: rtCamp/action-slack-notify@v2
-          env:
-            SLACK_WEBHOOK: ${{secrets.SLACK_GITHUB_NEWISSUEPR}}
-            SLACK_TITLE: 💬 New Discussion in ${{github.repository}} 💬
-            SLACK_MESSAGE: ${{steps.discussionmarkdown.outputs.text}}
-            MSG_MINIMAL: true
+  discussion:
+    if: github.event_name == 'discussion' && github.actor != 'asyncapi-bot' && github.actor != 'dependabot[bot]' && github.actor != 'dependabot-preview[bot]'
+    name: Notify slack on every new pull request
+    runs-on: ubuntu-latest
+    steps:
+      - name: Convert markdown to slack markdown for pull request
+        uses: LoveToKnow/slackify-markdown-action@v1.0.0
+        id: discussionmarkdown
+        with:
+          text: "[${{github.event.discussion.title}}](${{github.event.discussion.html_url}}) \n ${{github.event.discussion.body}}"
+      - name: Send info about pull request
+        uses: rtCamp/action-slack-notify@v2
+        env:
+          SLACK_WEBHOOK: ${{secrets.SLACK_GITHUB_NEWISSUEPR}}
+          SLACK_TITLE: 💬 New Discussion in ${{github.repository}} 💬
+          SLACK_MESSAGE: ${{steps.discussionmarkdown.outputs.text}}
+          MSG_MINIMAL: true

.github/workflows/link-check-cron.yml

@@ -8,30 +8,30 @@ on:
   schedule:
     # At 00:00 UTC on every Monday
     - cron: '0 0 * * 0'
-  
+
 jobs:
   External-link-validation-weekly:
     if: startsWith(github.repository, 'asyncapi/')
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+      - uses: actions/checkout@v3
+
+      # Checks the status of hyperlinks in .md files
+      - name: Check links
+        uses: gaurav-nelson/github-action-markdown-link-check@0a51127e9955b855a9bbfa1ff5577f1d1338c9a5 #1.0.14 but pointing to commit for security reasons
+        with:
+          use-quiet-mode: 'yes'
+          use-verbose-mode: 'yes'
 
-    # Checks the status of hyperlinks in .md files
-    - name: Check links
-      uses: gaurav-nelson/github-action-markdown-link-check@0a51127e9955b855a9bbfa1ff5577f1d1338c9a5 #1.0.14 but pointing to commit for security reasons
-      with:
-        use-quiet-mode: 'yes'
-        use-verbose-mode: 'yes'
-
-        # A configuration file can be included, indicating the properties of the link check action
-        # More information can be found here: https://github.com/tcort/markdown-link-check#config-file-format
-        # Create mlc_config.json file in the root of the directory
+          # A configuration file can be included, indicating the properties of the link check action
+          # More information can be found here: https://github.com/tcort/markdown-link-check#config-file-format
+          # Create mlc_config.json file in the root of the directory
 
-    - name: Report workflow run status to Slack
-      uses: 8398a7/action-slack@v3
-      with:
-        status: ${{ job.status }}
-        fields: repo,action,workflow
-      env:
+      - name: Report workflow run status to Slack
+        uses: 8398a7/action-slack@v3
+        with:
+          status: ${{ job.status }}
+          fields: repo,action,workflow
+        env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CI_FAIL_NOTIFY }}
-      if: failure() # Only, on failure, send a message on the 94_bot-failing-ci slack channel
+        if: failure() # Only, on failure, send a message on the 94_bot-failing-ci slack channel

.github/workflows/link-check-pr.yml

@@ -3,7 +3,7 @@
 
 name: Check Markdown links
 
-on: 
+on:
   pull_request_target:
     types: [synchronize, ready_for_review, opened, reopened]
     paths:
@@ -13,15 +13,16 @@ jobs:
   External-link-validation-on-PR:
     runs-on: ubuntu-latest
     steps:
-    - name: Checkout repo
-      uses: actions/checkout@v3
-    - name: Check links
-      uses: gaurav-nelson/github-action-markdown-link-check@0a51127e9955b855a9bbfa1ff5577f1d1338c9a5 #1.0.14 but pointing to commit for security reasons
-      with:
-        use-quiet-mode: 'yes'
-        use-verbose-mode: 'yes'
-        check-modified-files-only: 'yes' # Only modified files are checked on PRs
-
-        # A configuration file can be included, indicating the properties of the link check action
-        # More information can be found here: https://github.com/tcort/markdown-link-check#config-file-format
-        # Create mlc_config.json file in the root of the directory
+      - name: Checkout repo
+        uses: actions/checkout@v3
+      - name: Check links
+        uses: gaurav-nelson/github-action-markdown-link-check@0a51127e9955b855a9bbfa1ff5577f1d1338c9a5 #1.0.14 but pointing to commit for security reasons
+        with:
+          use-quiet-mode: 'yes'
+          use-verbose-mode: 'yes'
+          check-modified-files-only: 'yes' # Only modified files are checked on PRs
+
+
+          # A configuration file can be included, indicating the properties of the link check action
+          # More information can be found here: https://github.com/tcort/markdown-link-check#config-file-format
+          # Create mlc_config.json file in the root of the directory