Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename this repo? #45

Closed
fmvilas opened this issue Mar 15, 2021 · 11 comments · Fixed by #83
Closed

Rename this repo? #45

fmvilas opened this issue Mar 15, 2021 · 11 comments · Fixed by #83

Comments

@fmvilas
Copy link
Member

fmvilas commented Mar 15, 2021

Should we rename this repo to schemas or similar? It will not be only for Node.js but for other languages too.

@derberg
Copy link
Member

derberg commented Mar 15, 2021

spec-json-schemas?

@derberg
Copy link
Member

derberg commented Apr 19, 2021

@fmvilas what do you say about my name proposal?

@derberg
Copy link
Member

derberg commented May 14, 2021

@fmvilas I guess we can rename

just to explain my motivation for spec-json-schemas:

  • spec relates to spec repo
  • json schemas makes it clear it is json schemas, nothing else, unless there might be different in the future? spec-schemas ?

@fmvilas
Copy link
Member Author

fmvilas commented May 14, 2021

Sorry, I missed your comments above. Whatever makes sense. Just not asyncapi-node 👍

@jonaslagoni
Copy link
Member

I agree it is time to rename this repo, I have to keep reminding myself what the name is... I like spec-json-schemas as well 🙂

@derberg
Copy link
Member

derberg commented Jun 24, 2021

isn't npm package confusing for you too? like this @asyncapi/specs

@derberg
Copy link
Member

derberg commented Aug 5, 2021

@fmvilas @jonaslagoni so what do you think about the package name? shouldn't it be @asyncapi/spec-json-schemas too?

@fmvilas
Copy link
Member Author

fmvilas commented Aug 5, 2021

In my case, @asyncapi/specs is not confusing because I'm using it from a development context and if I'm "importing" or "requiring" the spec is because I want the spec version that is machine-readable, not the Markdown one. But that's just my perception.

@jonaslagoni
Copy link
Member

Same for me, @asyncapi/specs makes more sense.

@derberg
Copy link
Member

derberg commented Aug 5, 2021

sounds good to me, for me package name doesn't matter, can be what we have, just wanted to see how complicated rename will be.

@derberg
Copy link
Member

derberg commented Aug 5, 2021

repo renamed to spec-json-schemas

followup PR #83
update in link in contribution guide in spec repo can be done later (cause of auto redirects) so I will do it here in this PR -> asyncapi/spec#577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants