Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add release process instruction #577

Merged
merged 10 commits into from
Aug 12, 2021
Merged

docs: add release process instruction #577

merged 10 commits into from
Aug 12, 2021

Conversation

derberg
Copy link
Member

@derberg derberg commented Jul 1, 2021

  • release process instruction basing on the experience of 2.1 release
  • add codeowners file
  • remove obsolete docs that still talk about director and review process template, while we already have it as an issue template
  • update link to repo with json schema for the spec

Release process is not final, no step by step instructions, no flow diagrams. For me it is a good foundation that we can expand and polish (or Polish) with each release

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that it's the draft but two comments 😅

RELEASE_PROCESS.md Outdated Show resolved Hide resolved
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
@derberg
Copy link
Member Author

derberg commented Jul 1, 2021

@magicmatatjahu as you can see it is a draft so I'm ignoring any comments on grammar as this is the last item I look at when moving out of draft, now I don't care about grammar

RELEASE_PROCESS.md Outdated Show resolved Hide resolved
@derberg derberg added the 🐝 Process Related to Governance, Tools, or other meta work label Aug 6, 2021
@derberg derberg marked this pull request as ready for review August 6, 2021 16:39
magicmatatjahu
magicmatatjahu previously approved these changes Aug 9, 2021
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

RELEASE_PROCESS.md Outdated Show resolved Hide resolved
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
Co-authored-by: Fran Méndez <fmvilas@gmail.com>

### Kick off

We start by creating release branches and a placeholder for release notes in the AsyncAPI Blog.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels weird that release notes would be in the blog. shouldn't they be in the repos for tools and on the website with the spec docs? ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes for the website are there for a better presentation of the information and availability, like https://www.asyncapi.com/blog/release-notes-2.1.0. It is better to collaborate with other release contributors on a single PR

There is also always a release note in the GitHub release for a given tool, yup. There release here is for overall release summary, all features and thank you

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay perfect, just wanted to make sure release notes weren't only in the blog

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg derberg merged commit 8f441db into asyncapi:master Aug 12, 2021
@derberg derberg deleted the releaseprocess branch August 12, 2021 08:29
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐝 Process Related to Governance, Tools, or other meta work released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants