Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add specific binding schemas #224

Merged
merged 1 commit into from
Jul 8, 2022
Merged

feat: add specific binding schemas #224

merged 1 commit into from
Jul 8, 2022

Conversation

jonaslagoni
Copy link
Member

Description
This PR adds 2 changes to the JSON Schema documents.

  1. It fixes an issue where we allow all extensions regardless of the use of x-, which should not be allowed. Whether we want to propagate this across all versions, not so sure? 🤔
  2. It splits the generic bindingsObject into the 4 specific bindings for operation, channel, message, and server.

Related to asyncapi/spec#507
Related to asyncapi/bindings#113

@jonaslagoni jonaslagoni changed the title feat: add specific bindings feat: add specific binding schemas May 27, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

magicmatatjahu
magicmatatjahu reviewed May 27, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonaslagoni Two things:

  • It fixes an issue where we allow all extensions regardless of the use of x-, which should not be allowed. Whether we want to propagate this across all versions, not so sure? 🤔

    Do you mean that bug was only in bindingsObject?

  • I think that you should also update

    spec-json-schemas/definitions/3.0.0/components.json

    Line 71 in 067a129

    "serverBindings": {

@jonaslagoni
Copy link
Member Author

  • Do you mean that bug was only in bindingsObject?

Yes, as you can see here old vs new: https://github.com/asyncapi/spec-json-schemas/pull/224/files#diff-ecc755fd231eb52860aef0a5ea2c062296e87a0e38e1d1781d1782d47f690fe2R2-R8

We allowed the extension of any key, instead of only with specification extension x-.

  • I think that you should also update

Agreed, that will be next after this, and #225 is merged.

fmvilas
fmvilas approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

smoya
smoya approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonaslagoni
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 4e53622 into asyncapi:next-major-spec Jul 8, 2022
@jonaslagoni jonaslagoni deleted the feature/add_bindings branch July 8, 2022 11:02
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni mentioned this pull request Sep 28, 2022
Closed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 5.0.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.0.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoya smoya smoya approved these changes

@fmvilas fmvilas fmvilas approved these changes

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@dalelane dalelane Awaiting requested review from dalelane dalelane is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonaslagoni @asyncapi-bot @fmvilas @smoya @magicmatatjahu