chore: exclude tools/bundler/node_modules from final package

[Baldinof]

Description

On a fresh install of the package node_modules in the tools/bundler are included while it's only useful when publishing the package.

This will allow to save some space / bandwith when installing this package.

[github-actions]

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[smoya]

Hi @Baldinof! Thanks for submitting this PR!

tools/bundler is an isolated library, that has it's own package.json and could be used outside this project as well.
What do you think about moving that line of gitignore to a new .gitignore file located under tools/bundler dir?

Does it make sense?

[Baldinof]

Thanks for you answer @smoya :)

What do you mean by could be used outside this project as well? It can be installed separately?

This PR is to remove the embeddings of the node_modules in tools/bundler from the @asyncapi/specs package tarball.

I don't think adding a .gitignore under tools/bundler.

But maybe tools/bundler is part of the public API of this package but it does not seem to be the case (it's only used to generate files for the release).

[smoya]

Thanks for you answer @smoya :)

What do you mean by could be used outside this project as well? It can be installed separately?

This PR is to remove the embeddings of the node_modules in tools/bundler from the @asyncapi/specs package tarball.

I don't think adding a .gitignore under tools/bundler.

But maybe tools/bundler is part of the public API of this package but it does not seem to be the case (it's only used to generate files for the release).

As you mentioned, the tools/bundler is expected to be detached from the @asyncapi/specs. It is also isolated in terms of code (all code is located only in tools/bundler), that's why I suggest it needs an independent .gitignore file under /tools/bundler and not to mix with the main .gitignore file in the root.

[Baldinof]

The code change is about .npmignore, not .gitignore to ignore files in the npm package tarball.

Node modules are already ignored for git thanks to this

[smoya]

The code change is about .npmignore, not .gitignore to ignore files in the npm package tarball.

Node modules are already ignored for git thanks to this

omg 🤦 I swear I read .gitignore in the changeset... shame on me! Excuse me for making you waste your time on that matter 🙏

[Baldinof]

omg 🤦 I swear I read .gitignore in the changeset... shame on me! Excuse me for making you waste your time on that matter 🙏

No worries :)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[smoya]

LGTM!🙌

[smoya]

@jonaslagoni could you do a quick check and merge if you agree? Thanks!

[jonaslagoni]

Thanks @Baldinof 👌

[jonaslagoni]

/rtm

[asyncapi-bot]

🎉 This PR is included in version 6.0.0-next-major-spec.15 🎉

The release is available on:

• npm package (@next-major-spec dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[asyncapi-bot]

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀