Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: strip custom referencing mechanism from Channel Item #777

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

char0n
Copy link
Collaborator

@char0n char0n commented May 4, 2022

This is attempt to get RFC(#699) from Stage 1 to Stage 2. It has already been stipulated in #607 that this is reasonable course of action which avoids future ambiguity and simplifies the specification.

Refs #699

@char0n char0n force-pushed the next-major-spec branch from aca432d to 880f197 Compare May 4, 2022 07:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@char0n char0n changed the title feat: strip Channel Item from custom referencing mechanism feat: strip custom referencing mechanism from Channel Item May 4, 2022
@char0n
Copy link
Collaborator Author

char0n commented May 4, 2022

Link checker is producing errors in CI. Seems to be unrelated with my changeset.

@char0n char0n changed the title feat: strip custom referencing mechanism from Channel Item RFC: strip custom referencing mechanism from Channel Item May 4, 2022
@char0n char0n changed the title RFC: strip custom referencing mechanism from Channel Item feat: strip custom referencing mechanism from Channel Item May 4, 2022
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👏

@fmvilas
Copy link
Member

fmvilas commented May 5, 2022

/dnm

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fmvilas
Copy link
Member

fmvilas commented Jul 5, 2022

/rtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants