Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Pulsar bindings to the specification. #882

Merged
merged 23 commits into from
Jan 31, 2023
Merged

feat: add Pulsar bindings to the specification. #882

merged 23 commits into from
Jan 31, 2023

Conversation

VisualBean
Copy link
Contributor

@VisualBean VisualBean commented Dec 9, 2022 •
edited
Loading

title: "Add pulsar bindings and protocol to the specification"

Related issue(s):

Pulsar binding PR
Json schema update PR

The pulsar binding was finalized in the Bindings repository.
This PR adds the new pulsar binding objects, to the Server and Channel bindings list.
Along with adding "pulsar" to the protocol list.

char0n and others added 16 commits September 29, 2022 08:49
@char0n @smoya
@magicmatatjahu @whitlockjc @derberg
feat: release for version 2.5.0 of the spec (asyncapi#842)
4ed4055 
Co-authored-by: Sergio Moya <1083296+smoya@users.noreply.github.com>
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
Co-authored-by: Jeremy Whitlock <jwhitlock@apache.org>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@fmvilas
chore: add Sergio and Vladimir as code owners (asyncapi#846)
949a9ff
@asyncapi-bot
ci: update generic workflows (asyncapi#851)
529cc06 
Co-authored-by: asyncapi-bot <info@asyncapi.io>
@asyncapi-bot @derberg
ci: update generic workflows (asyncapi#855)
6476aaf 
Co-authored-by: asyncapi-bot <info@asyncapi.io>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@asyncapi-bot @asyncapi-bot-eve @derberg
ci: update generic workflows (asyncapi#857)
d110932 
Co-authored-by: asyncapi-bot-eve <bot+eve@asyncapi.io>
Co-authored-by: asyncapi-bot <info@asyncapi.io>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@asyncapi-bot
ci: update generic workflows (asyncapi#866)
f2e0ed7
@dependabot
chore(deps): bump @actions/core from 1.6.0 to 1.9.1 in /.github/workf…
8912e4b 
…lows/scripts/mailchimp (asyncapi#867)
@smoya
docs: set proper indentation for the TOC (asyncapi#853)
9549230
@asyncapi-bot
ci: update generic workflows (asyncapi#871)
226447a
@codingtenshi
ci: remove not needed workflow (asyncapi#872)
d5c8960
@derberg
chore: fix example for operation security (asyncapi#873)
eb8bb65
@magicmatatjahu
chore: update asyncapi versions in the social-media example (asyncapi…
90e6a99 
…#876)
@asyncapi-bot
ci: update generic workflows (asyncapi#877)
77cb157
@asyncapi-bot
ci: update generic workflows (asyncapi#879)
1e3ec47
@VisualBean
Update asyncapi.md
55aac63
@VisualBean
Update asyncapi.md
7f08fb1
github-actions[bot]
github-actions bot reviewed Dec 9, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@VisualBean VisualBean changed the title add Pulsar bindings to the specification. chore: add Pulsar bindings to the specification. Dec 9, 2022
@VisualBean VisualBean changed the title chore: add Pulsar bindings to the specification. feat: add Pulsar bindings to the specification. Dec 9, 2022
@VisualBean
Copy link
Contributor Author

Which Schema version should I update?

fmvilas
fmvilas requested changes Dec 9, 2022
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far looks good to me but would you mind adding the operation and message bindings too? Even if we don't have any of those in the Pulsar binding yet but just so we have it here as a placeholder.

@fmvilas
Copy link
Member

fmvilas commented Dec 9, 2022 •
edited
Loading

Oh, I also forgot two things:

  1. You have to add pulsar to the 2.6.0 file in the spec-json-schemas repo. This file doesn't exist yet so I recommend you duplicate the 2.5.0 one and add it there.
  2. You're now a code owner of the pulsar binding in the bindings repo so you have the right to join the TSC 🎉 Please add yourself to https://github.com/asyncapi/community/blob/master/TSC_MEMBERS.json.

@VisualBean
Copy link
Contributor Author

So far looks good to me but would you mind adding the operation and message bindings too? Even if we don't have any of those in the Pulsar binding yet but just so we have it here as a placeholder.

I have added these.

@fmvilas fmvilas changed the base branch from master to next-spec January 17, 2023 08:19
@fmvilas fmvilas dismissed stale reviews from derberg, char0n, and themself January 17, 2023 08:19

The base branch was changed.

@fmvilas
Copy link
Member

fmvilas commented Jan 17, 2023

Changed the base branch but got conflicts now. @VisualBean I can't fix the conflicts for you because I don't have permission on your repo/branch. Please go ahead and fix them and that should be all.

@VisualBean
Copy link
Contributor Author

Changed the base branch but got conflicts now. @VisualBean I can't fix the conflicts for you because I don't have permission on your repo/branch. Please go ahead and fix them and that should be all.

Awesome, thanks. I'll get them worked out

@derberg
Copy link
Member

derberg commented Jan 18, 2023

@VisualBean due to update in next-spec branch there are some conflicts that you need to resolve, sorry

can you also change target in asyncapi/spec-json-schemas#295 please, point to next-spec as well

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AceTheCreator
Copy link
Member

@fmvilas can you merge this PR?

@derberg
Copy link
Member

derberg commented Jan 30, 2023

@char0n can you approve again?

@dalelane @smoya this one is quick to approve as you were already involved in binding-related PR to add new binding

smoya
smoya approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derberg
Copy link
Member

derberg commented Jan 31, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 35693fb into asyncapi:next-spec Jan 31, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-spec.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Jan 31, 2023

Recent comments about the release from the bot were added by mistake. More details in #899

This was referenced Jan 31, 2023
Closed
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@derberg derberg derberg approved these changes

@dalelane dalelane dalelane approved these changes

@smoya smoya smoya approved these changes

@fmvilas fmvilas fmvilas approved these changes

@char0n char0n char0n left review comments

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
🏁 Accepted (RFC 3) RFC Stage 3 (See CONTRIBUTING.md) ready-to-merge released on @next-major-spec released on @next-spec released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.