Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix websocket-gemini message's payload example #884

Merged
merged 2 commits into from
Dec 20, 2022
Merged

docs: fix websocket-gemini message's payload example #884

merged 2 commits into from
Dec 20, 2022

Conversation

magicmatatjahu
Copy link
Member

title: "fix: websocket-gemini message's payload example"

Related issue(s):
asyncapi/studio#526

Fix the payload example in one of the messages of the websocket-gemini example.

@magicmatatjahu magicmatatjahu changed the title fix: websocket-gemini message's payload example docs: websocket-gemini message's payload example Dec 14, 2022
@magicmatatjahu magicmatatjahu changed the title docs: websocket-gemini message's payload example docs: fix websocket-gemini message's payload example Dec 14, 2022
derberg
derberg approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

char0n
char0n approved these changes Dec 19, 2022
View reviewed changes
Copy link
Collaborator

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@derberg Volta.net
Copy link
Member

derberg commented Dec 19, 2022

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @derberg! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 6c252c2 into asyncapi:master Dec 20, 2022
@magicmatatjahu magicmatatjahu deleted the fix/websocket-gemini-example branch December 20, 2022 08:18
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni mentioned this pull request Dec 4, 2023
Merged
jonaslagoni added a commit to jonaslagoni/spec that referenced this pull request Dec 4, 2023
@jonaslagoni
chore: apply asyncapi#884
297b336
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@fmvilas fmvilas fmvilas approved these changes

@char0n char0n char0n approved these changes

@dalelane dalelane Awaiting requested review from dalelane dalelane is a code owner

@smoya smoya Awaiting requested review from smoya smoya is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@magicmatatjahu @derberg @asyncapi-bot @char0n @fmvilas