Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new schema reference object to enable nonjson refs in future #917

Closed
wants to merge 2 commits into from

Conversation

derberg
Copy link
Member

@derberg derberg commented Mar 30, 2023

PS. Let's pretend I created a branch in a fork, and not upstream, ok? 😅


Breaking Change

It must target 3.0


This PR is a result of:

What you see here is that Reference Object gets some more clarification and there is new Schema Reference Object that allows to have specification extensions.

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derberg
Copy link
Member Author

derberg commented May 11, 2023

keeping it open, but looks like it is not needed for 3.0 and will be done in 3.1

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Sep 9, 2023
@derberg derberg removed the stale label Oct 5, 2023
@jemacineiras
Copy link

Hi team,
Seeing this PR I am just curious about how AsyncApi V3 will handle Schemas Registry configuration for external schemas definition storage, like Avro, Protobuf or also Json Schema.
I had build some tools to generate code base on AsyncApi definition and some for testing, mostly of them support definition of schemas using the $Ref approach but then it came to have the schema definition in a place like Confluent Schema Registry, ApiCurio Schema Registry, Azure Schema Registry and so, I don't find it.
I was thinking about how it can be solved, and looks a complex problem since base on your infrastructure you can have one schema registry server, or several, base on your environments.
I think this is something it should be kept in mind, since mostly of the people share AsyncApi documents between applications in order to generate code base on (myself have a small tool who create code where you can combine OpenApi and AsyncAp definitions).
If you wish I can open a suggestion base on this PR.. a PR base on a PR.. looks naughty.
Can you give me any light about?

Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Mar 22, 2024
@smoya smoya removed the stale label Mar 22, 2024
@derberg
Copy link
Member Author

derberg commented Mar 25, 2024

I'm closing it for now as it requires fresh look once we start working on it

@derberg derberg closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants