Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update examples so messages reference channel messages #997

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

derberg
Copy link
Member

@derberg derberg commented Nov 28, 2023

addressing #991

channels and servers were correct anyway as we never had servers and channels under components before, so converter did not handle setting refs to components

this PR:

  • fixes messages references
  • solves some naming errors, left overs that I did not fix with my previous PR for adjusting examples

I was fixing examples to make sure they are v3 valid:

  • by adding # yaml-language-server: $schema=https://raw.githubusercontent.com/asyncapi/spec-json-schemas/next-major-spec/schemas/3.0.0-without-%24id.json to the file and making sure nothing blinks red
  • changed references, I was making sure they are valid links, VSCode makes them active links

@derberg derberg changed the title chore: update examples to match #991 fixes chore: update examples so messages reference channel messages Nov 28, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg
Copy link
Member Author

derberg commented Nov 29, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 1a8c669 into asyncapi:next-major-spec Nov 29, 2023
16 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants