Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blog): add release notes for 2.4 release #634

Merged
merged 21 commits into from
Apr 28, 2022
Merged

feat(blog): add release notes for 2.4 release #634

merged 21 commits into from
Apr 28, 2022

Conversation

smoya
Copy link
Member

@smoya smoya commented Mar 21, 2022 •
edited
Loading

Description

This pull request is a placeholder draft of the release notes for the upcoming 2.4 release.

Contributes to: asyncapi/spec#735

@netlify
Copy link

netlify bot commented Mar 21, 2022 •
edited
Loading

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 28f59fe
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/626a45049e90780008c3e537
😎 Deploy Preview https://deploy-preview-634--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@smoya smoya mentioned this pull request Mar 21, 2022
Closed
55 tasks
@smoya
Copy link
Member Author

smoya commented Apr 19, 2022

/au

@smoya smoya force-pushed the 2022-04-release branch from 17a4da5 to 5d2b811 Compare April 21, 2022 10:44
char0n
char0n previously approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me!

@smoya smoya force-pushed the 2022-04-release branch from f9f6452 to 1ceb74d Compare April 22, 2022 15:16
smoya
smoya commented Apr 22, 2022
View reviewed changes
pages/blog/release-notes-2.4.0.md

This new feature was contributed by [Daniel Kocot](https://github.com/danielkocot). For more detail, see this [pull request](https://github.com/asyncapi/spec/pull/717) and the [Github issue where this change was discussed](https://github.com/asyncapi/spec/issues/707).

## Security can now be defined at Operation level
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sekharbans-ebay would you like to review the release notes I wrote here about your recent contribution? Also check the example in detail, please.
Thanks!

@smoya smoya marked this pull request as ready for review April 22, 2022 15:18
@smoya smoya changed the title chore(blog): add release notes for 2.4 release feat(blog): add release notes for 2.4 release Apr 22, 2022
@github-actions
Copy link

github-actions bot commented Apr 22, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 43
🟠 Accessibility 75
🟠 Best practices 83
🟢 SEO 90
🔴 PWA 30

Lighthouse ran on https://deploy-preview-634--asyncapi-website.netlify.app/

@smoya smoya force-pushed the 2022-04-release branch from a62c52c to 7fdd7a0 Compare April 22, 2022 17:27
quetzalliwrites
quetzalliwrites requested changes Apr 22, 2022
View reviewed changes
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my review @smoya 😸

@smoya
Copy link
Member Author

smoya commented Apr 24, 2022

As usual, terrific review @alequetzalli. I always learn a lot from them! Thanks!

@smoya smoya force-pushed the 2022-04-release branch from 7176386 to b42b67e Compare April 26, 2022 11:23
@smoya smoya requested a review from quetzalliwrites April 26, 2022 18:15
@smoya smoya force-pushed the 2022-04-release branch from 950be8d to e90ee7a Compare April 26, 2022 20:04
quetzalliwrites
quetzalliwrites previously approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌈 ⭐ 🌟

WaleedAshraf
WaleedAshraf previously approved these changes Apr 27, 2022
View reviewed changes
@smoya smoya dismissed stale reviews from WaleedAshraf and quetzalliwrites via 6dc94a4 April 27, 2022 14:14
smoya
smoya commented Apr 27, 2022
View reviewed changes
pages/blog/release-notes-2.4.0.md
- auth:read
```

Thanks to [Sekharbans](https://github.com/sekharbans-ebay), is now possible to increase security granularity by defining a set of security requirements at Operation level. For more detail, see [Sekharban's `/spec #584` pull request](https://github.com/asyncapi/spec/pull/584) and the [Github issue where Sekharban's suggested feature was discussed](https://github.com/asyncapi/spec/issues/584).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alequetzalli I added those two lines as I missed adding the link to the PR and Issue on this feature.
Would you mind giving a check and +1 if you agree please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why limit to a +1 when I can do an APPROVE PR STAT 😸

@smoya smoya requested a review from quetzalliwrites April 27, 2022 14:15
@smoya
Copy link
Member Author

smoya commented Apr 27, 2022

Netlify build failed. @​fmvilas​ ​@​derberg​ ​can you relaunch it?

@smoya @derberg
Update pages/blog/release-notes-2.4.0.md
5753005 
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@derberg derberg merged commit 9739966 into asyncapi:master Apr 28, 2022
@derberg
Copy link
Member

derberg commented Apr 28, 2022

@alequetzalli I merged without waiting for your final ✅ as all changes added by @smoya were purely technical 🙏🏼

@smoya smoya deleted the 2022-04-release branch April 28, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkocot danielkocot danielkocot left review comments

@char0n char0n char0n left review comments

@WaleedAshraf WaleedAshraf WaleedAshraf left review comments

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@fmvilas fmvilas Awaiting requested review from fmvilas

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@quetzalliwrites quetzalliwrites Awaiting requested review from quetzalliwrites quetzalliwrites is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

Assignees
No one assigned
Labels
autoupdate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@smoya @derberg @char0n @danielkocot @WaleedAshraf @quetzalliwrites @asyncapi-bot