Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for processing multiple paths #32

Closed
atc0005 opened this issue Sep 30, 2019 · 2 comments · Fixed by #64
Closed

Add support for processing multiple paths #32

atc0005 opened this issue Sep 30, 2019 · 2 comments · Fixed by #64

Comments

@atc0005
Copy link
Owner

atc0005 commented Sep 30, 2019

As of v0.3.1, only one path is supported at a time.

This should probably go in before work on #31 commences.

@atc0005 atc0005 added enhancement New feature or request command-line config labels Sep 30, 2019
@atc0005 atc0005 added this to the Future milestone Sep 30, 2019
@atc0005
Copy link
Owner Author

atc0005 commented Oct 1, 2019

A few semi-random thoughts:

  • loop over a slice of locations?
  • add in support for using goroutines?
    • write so that one goroutine per location could be used, but lock the logic to just one goroutine by default unless overridden by configuration?

@atc0005
Copy link
Owner Author

atc0005 commented Oct 22, 2019

  • loop over a slice of locations?

This is the direction I'm currently going with this. It seems simpler and easier to implement as a "first draft".

  • add in support for using goroutines?

    • write so that one goroutine per location could be used, but lock the logic to just one goroutine by default unless overridden by configuration?

Logging would probably need to be tweaked here to carefully indicate where the messages are coming from (e.g., what directory is currently being processed for a log message).

Since the plan is to implement support for cron-like behavior, supporting multiple goroutines may not be needed; due to the semi-frequent cleanup operations and the limited age-based checks, it is doubtful (at this time) that concurrency would be needed to prune all files before the next execution schedule/event occurs.

atc0005 added a commit that referenced this issue Oct 23, 2019
- Allow specifying one or more paths via command-line
  or environment variable

- Update documentation to reflect multiple paths

- Update Makefile and test scripts to work with
  multiple paths

- Add small test script to generate output for use
  with README examples

refs #32
atc0005 added a commit that referenced this issue Oct 23, 2019
- Allow specifying one or more paths via command-line
  or environment variable

- Update documentation to reflect multiple paths

- Update Makefile and test scripts to work with
  multiple paths

- Add small test script to generate output for use
  with README examples

refs #32
atc0005 added a commit that referenced this issue Oct 23, 2019
- Allow specifying one or more paths via command-line
  or environment variable

- Update documentation to reflect multiple paths

- Update Makefile and test scripts to work with
  multiple paths

- Add small test script to generate output for use
  with README examples

refs #32
atc0005 added a commit that referenced this issue Oct 23, 2019
- Allow specifying one or more paths via command-line
  or environment variable

- Update documentation to reflect multiple paths

- Update Makefile and test scripts to work with
  multiple paths

- Add small test script to generate output for use
  with README examples

refs #32
atc0005 added a commit that referenced this issue Oct 23, 2019
- Allow specifying one or more paths via command-line
  or environment variable

- Update documentation to reflect multiple paths

- Update Makefile and test scripts to work with
  multiple paths

- Add small test script to generate output for use
  with README examples

- Minor logging tweaks to record additional field
  values that could be useful when troubleshooting

refs #32
atc0005 added a commit that referenced this issue Oct 23, 2019
- Allow specifying one or more paths via command-line
  or environment variable

- Update documentation to reflect multiple paths

- Update Makefile and test scripts to work with
  multiple paths

- Add small test script to generate output for use
  with README examples

- Minor logging tweaks to record additional field
  values that could be useful when troubleshooting

refs #32
atc0005 added a commit that referenced this issue Oct 23, 2019
- Allow specifying one or more paths via command-line
  or environment variable

- Update documentation to reflect multiple paths

- Update Makefile and test scripts to work with
  multiple paths

- Add small test script to generate output for use
  with README examples

- Minor logging tweaks to record additional field
  values that could be useful when troubleshooting

refs #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant