Added a way towards easy builds #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noticed that there's already a Docker image that is used for CI, so adjusted the Makefile to use that one instead of my own Dockerfile. :) Added a PR for that Docker image in the respective repository with some improvements. |
|
Hey thank you for the PR Does this PR changes some other files or only adds the Dockerfile and Makefile in root on the repo ? |
|
This just adds another make target ( |
|
Perfect :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I believe that it's very important, for the success of a project (and forgetting contributions), that compilation is as easy as possible,
to make it as painless as possible. With Docker, there's no worry about having the right SDK's or having the code folder in the right location, it just works.
I've added the Dockerfile and a simple Makefile to show how easy it can be. If you want, I can make a separate repository for this 'builder', but I think it's easier to maintain if the compilation environment is kept close to the code.
Let me know what you think :)
Have a great day!
Ruben