Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search #18

Closed
tangjeff0 opened this issue May 5, 2020 · 2 comments
Closed

Search #18

tangjeff0 opened this issue May 5, 2020 · 2 comments

Comments

@tangjeff0
Copy link
Collaborator

tangjeff0 commented May 5, 2020 •
edited
Loading

Core meat of this issue is writing logic to scan through user's :node/titles and :block/strings when the input is changed, and showing first N recommendations. Don't worry too much about nice looking dropdown and other UX things. Can be handled by later issues when making user-friendly.

Search with [[]] and (()) are actually subproblems of the search bar, since the search bar queries titles and blocks.

Demo

search
@jeroenvandijk
Copy link
Contributor

FYI made a start here #20

@tangjeff0 tangjeff0 linked a pull request May 27, 2020 that will close this issue
First steps for search box #20
Closed
5 tasks
@tangjeff0 tangjeff0 changed the title Implement search functionality Search May 27, 2020
@tangjeff0 tangjeff0 mentioned this issue Jun 4, 2020
Closed
11 tasks
@tangjeff0
Copy link
Collaborator Author

Superseded by #126

  • should be trivial to do inline search now

neotyk added a commit that referenced this issue Oct 25, 2021
@neotyk
Merge pull request #18 from sid597/fix/atomic-transactions
bd831ef 
last remaining location to make atomic transactions
sid597 added a commit to sid597/athens that referenced this issue Mar 16, 2022
@sid597
parse and render ref in comments (athensresearch#18)
920de24 
* parse and render ref in comments

* ref inside right side comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

First steps for search box jeroenvandijk/athens
2 participants
@jeroenvandijk @tangjeff0