Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing page title renames all occurrences #62

Closed
tangjeff0 opened this issue May 15, 2020 · 3 comments
Closed

Editing page title renames all occurrences #62

tangjeff0 opened this issue May 15, 2020 · 3 comments

Comments

@tangjeff0
Copy link
Collaborator

tangjeff0 commented May 15, 2020 •
edited
Loading

Two edge cases:

Demo

rename-page-title
@jelmerderonde
Copy link
Contributor

Wanted to try creating this, but I guess it is easier to wait till #70 is merged.

This was referenced May 17, 2020
Closed
Merged
@jeroenvandijk
Copy link
Contributor

One more edge case @tangjeff0: changing the title to something very short like "a". Causes many unlinked references (endless stream of warnings about content-editable in this case). Found after testing #86. We can set a minimum character length for unlinked references I think

@tangjeff0
Copy link
Collaborator Author

Good idea. Don’t think Roam even does that. @jeroenvandijk

@tangjeff0 tangjeff0 mentioned this issue May 27, 2020
Closed
7 tasks
@tangjeff0 tangjeff0 reopened this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add event :node/rename that also updates referencing blocks jelmerderonde/athens
3 participants
@jeroenvandijk @jelmerderonde @tangjeff0